Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] wvstreams: Pass -fPIC to CFLAGS when building PIC objects
Date: Thu, 20 Jun 2013 17:06:21 +0200	[thread overview]
Message-ID: <87ehbwom8i.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1371737650-12310-1-git-send-email-markos.chandras@gmail.com> (Markos Chandras's message of "Thu, 20 Jun 2013 15:14:10 +0100")

>>>>> "Markos" == Markos Chandras <markos.chandras@gmail.com> writes:

 Markos> From: Markos Chandras <markos.chandras@imgtec.com>
 Markos> The argp bundled dependency which is linked to the libwvutils.so
 Markos> shared library, wasn't built with -fPIC.
 Markos> MIPS will refuce to link a non-PIC library with a shared one.

 Markos> We fix this problem by appending -fPIC to CFLAGS and build all the
 Markos> shared objects with -fPIC.

 Markos> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
 Markos> ---
 Markos>  package/wvstreams/wvstreams.mk | 4 ++++
 Markos>  1 file changed, 4 insertions(+)

 Markos> diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk
 Markos> index 65f48d4..fddaad7 100644
 Markos> --- a/package/wvstreams/wvstreams.mk
 Markos> +++ b/package/wvstreams/wvstreams.mk
 Markos> @@ -27,6 +27,10 @@ WVSTREAMS_CONF_OPT += \
 Markos>  # needed for openssl detection when statically linking (as ssl needs lz)
 Markos>  WVSTREAMS_CONF_ENV += LIBS=-lz
 
 Markos> +ifneq ($(BR2_PREFER_STATIC_LIB),y)
 Markos> +	WVSTREAMS_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -fPIC"

Committed with this changed to a +=, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2013-06-20 15:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 14:14 [Buildroot] [PATCH v2] wvstreams: Pass -fPIC to CFLAGS when building PIC objects Markos Chandras
2013-06-20 14:28 ` Markos Chandras
2013-06-20 15:06 ` Peter Korsgaard [this message]
2013-06-20 20:21   ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehbwom8i.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox