Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Config: unbreak check-source caused by empty defconfigs
Date: Thu, 14 Jul 2011 13:34:05 +0200	[thread overview]
Message-ID: <87ei1tcd02.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <201107141228.54544.yann.morin.1998@anciens.enib.fr> (Yann E. MORIN's message of "Thu, 14 Jul 2011 12:28:54 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

Hi,

 Yann> That's because, 'source-check' spawns a second make to run '_source-check'
 Yann> which in turn runs a third make for 'source' with DL_MODE=SOURCE_CHECK

Ahh yes, so your problem is the first run - E.G. with annotation added:

diff --git a/Makefile b/Makefile
index 2f3802c..64bcafc 100644
--- a/Makefile
+++ b/Makefile
@@ -22,6 +22,7 @@
 # Just run 'make menuconfig', configure stuff, then run 'make'.
 # You shouldn't need to mess with anything beyond this point...
 #--------------------------------------------------------------
+$(warning MAKECMDGOALS=$(MAKECMDGOALS))
 
 # Set and export the version string
 export BR2_VERSION:=2011.08-git

We get:

make external-deps
Makefile:25: MAKECMDGOALS=external-deps
Makefile:25: MAKECMDGOALS=source

 Yann> Now, I wonder how to properly fix this.

 Yann> Either we check for 'source' and '_source-check', or we change
 Yann> the way '_source-check' behaves. I'll push a patch for the second
 Yann> case, so you can see what I have in my head about this... ;-)

We could probably combine source-check and _source-check, but as far as
I can see we would need to handle both source/source-check/external-deps

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2011-07-14 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 21:47 [Buildroot] [PATCH] Config: unbreak check-source caused by empty defconfigs Yann E. MORIN
2011-07-14  8:14 ` Thomas Petazzoni
2011-07-14 10:28   ` Yann E. MORIN
2011-07-14 11:34     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ei1tcd02.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox