From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/10] autotools: allow host package to use <pkg>_MAKE_ENV and <pkg>_MAKE
Date: Mon, 24 Jan 2011 22:04:35 +0100 [thread overview]
Message-ID: <87ei82qaho.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <178a42636fdb3c6119ca718a24b14a22c9c9df28.1295866866.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 24 Jan 2011 12:01:34 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> This will be needed by the Python interpreter package.
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> ---
Thomas> package/Makefile.autotools.in | 2 +-
Thomas> 1 files changed, 1 insertions(+), 1 deletions(-)
Thomas> diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
Thomas> index de0a355..d445348 100644
Thomas> --- a/package/Makefile.autotools.in
Thomas> +++ b/package/Makefile.autotools.in
Thomas> @@ -200,7 +200,7 @@ endif
Thomas> #
Thomas> ifndef $(2)_INSTALL_CMDS
Thomas> define $(2)_INSTALL_CMDS
Thomas> - $(HOST_MAKE_ENV) $(MAKE) -C $$($$(PKG)_SRCDIR) install
Thomas> + $(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) -C $$($$(PKG)_SRCDIR) install
Hmm, I don't really like this. Packages might be adding target specific
stuff to their $PKG_MAKE_ENV - E.G.:
lvm2/lvm2.mk:LVM2_MAKE_ENV = CC="$(TARGET_CC)"
Wouldn't it make more sense to add a HOST_$PKG_MAKE_ENV and use it just
like we do for $PKG_MAKE_ENV (E.G. at build and install time)?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-01-24 21:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 11:01 [Buildroot] [pull request] Pull request for branch for-2011.02/python-bump Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 01/10] python: Move to version 2.7 Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 02/10] python: Port the python2.4 patches to 2.7 Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 03/10] python: Add the needed patches to compile python2.7 in buildroot Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 04/10] python: Fix make install (Workaround python's bug #1669349) Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 05/10] libffi: new package Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 06/10] autotools: allow host package to use <pkg>_MAKE_ENV and <pkg>_MAKE Thomas Petazzoni
2011-01-24 21:04 ` Peter Korsgaard [this message]
2011-01-25 7:55 ` Thomas Petazzoni
2011-01-25 9:02 ` Peter Korsgaard
2011-01-24 11:01 ` [Buildroot] [PATCH 07/10] python: convert to autotargets, bump to 2.7.1, many improvements Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 08/10] Remove .py or .pyc depending on Python configuration Thomas Petazzoni
2011-01-24 21:20 ` Peter Korsgaard
2011-01-24 11:01 ` [Buildroot] [PATCH 09/10] python-serial: new package Thomas Petazzoni
2011-01-24 21:22 ` Peter Korsgaard
2011-01-24 11:01 ` [Buildroot] [PATCH 10/10] python-mad: " Thomas Petazzoni
2011-01-24 21:23 ` Peter Korsgaard
2011-01-25 8:03 ` [Buildroot] [pull request] Pull request for branch for-2011.02/python-bump Thomas Petazzoni
2011-01-25 21:17 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei82qaho.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox