Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add radvd to the list of packages
Date: Tue, 27 Jan 2009 18:03:14 +0100	[thread overview]
Message-ID: <87eiyoznot.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <200901271757.28001.amand.tihon@alrj.org> (Amand Tihon's message of "Tue\, 27 Jan 2009 17\:57\:19 +0100")

>>>>> "Amand" == Amand Tihon <amand.tihon@alrj.org> writes:

 Amand> Add radvd, the IPv6 router advertisement daemon.
 Amand> Signed-off-by: Amand Tihon <amand.tihon@alrj.org>
 Amand> ---

 Amand> Note that it has only been tested on avr32 (ngw100) using
 Amand> Atmel's latest stable buildroot (v2.3.0). A basic init script
 Amand> is included.

I'll take a closer look at this after the release, but here's a few
comments:

 Amand> +++ b/package/radvd/Config.in
 Amand> @@ -0,0 +1,9 @@
 Amand> +config BR2_PACKAGE_RADVD
 Amand> +	bool "radvd"
 Amand> +	default n
 Amand> +	select BR2_PACKAGE_FLEX
 Amand> +	depends on BR2_PACKAGE_KMOD_IPV6

KMOD_IPV6 - What's that?

I would have expected a depends on BR2_INET_IPV6

 Amand> +++ b/package/radvd/radvd-1.2-avr32.patch
 Amand> @@ -0,0 +1,21 @@
 Amand> +diff -ru radvd-1.2_vanilla/config.sub radvd-1.2/config.sub
 Amand> +--- radvd-1.2_vanilla/config.sub	2003-11-21 15:53:23.000000000 +0100

Isn't that handled by the CONFIG_UPDATE stuff?

 Amand> diff --git a/package/radvd/radvd.mk b/package/radvd/radvd.mk
 Amand> new file mode 100644
 Amand> index 0000000..29f4d8d
 Amand> --- /dev/null
 Amand> +++ b/package/radvd/radvd.mk
 Amand> @@ -0,0 +1,64 @@
 Amand> +#############################################################
 Amand> +#
 Amand> +# radvd
 Amand> +#
 Amand> +#############################################################
 Amand> +
 Amand> +RADVD_VERSION=1.2
 Amand> +RADVD_SOURCE=radvd-$(RADVD_VERSION).tar.gz
 Amand> +RADVD_SITE=http://www.litech.org/radvd/dist/
 Amand> +RADVD_DIR=$(BUILD_DIR)/radvd-$(RADVD_VERSION)
 Amand> +RADVD_CAT:=$(ZCAT)
 Amand> +
 Amand> +$(DL_DIR)/$(RADVD_SOURCE):
 Amand> +	$(WGET) -P $(DL_DIR) $(RADVD_SITE)/$(RADVD_SOURCE)
 Amand> +
 Amand> +$(RADVD_DIR)/.unpacked: $(DL_DIR)/$(RADVD_SOURCE)

Please use Makefile.autotools.in instead of adding a new old-style
package.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-01-27 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 16:57 [Buildroot] [PATCH] Add radvd to the list of packages Amand Tihon
2009-01-27 17:03 ` Peter Korsgaard [this message]
2009-01-27 21:14 ` Amand Tihon
  -- strict thread matches above, loose matches on Subject: below --
2009-01-28 20:31 Amand Tihon
2009-01-28 20:54 ` Peter Korsgaard
2009-01-28 21:35 ` Amand Tihon
2009-01-28 21:39   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eiyoznot.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox