From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, arnout@mind.be
Cc: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libdrm: disable tests
Date: Tue, 26 Mar 2024 16:01:40 +0100 [thread overview]
Message-ID: <87frwd9gvf.fsf@48ers.dk> (raw)
In-Reply-To: <87sf0eg2xp.fsf@48ers.dk> (Peter Korsgaard's message of "Mon, 25 Mar 2024 08:56:18 +0100")
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>> Disable tests to avoid the following build failure with amdgpu and gcc 5
>> if cunit is built before libdrm:
>> In file included from ../tests/amdgpu/shader_test_util.c:10:0:
>> ../tests/amdgpu/shader_code.h:113:2: error: initializer element is not constant
>> ps_##_ps##_shader_patchinfo_code_size_gfx##_n, \
>> ^
>> tests can be disabled since
>> https://gitlab.freedesktop.org/mesa/drm/-/commit/46d1e99a5d291b22d86ac52710b079491beedff8
>> Fixes:
>> - http://autobuild.buildroot.org/results/612aad1fa642993da36bbec6c16c9020ac283e34
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.
Hmm, I think I was too fast here. The libdrm tests also include the
handy utilities like modetest and modeprint, so it is not great to
unconditionally disable them.
Maybe we should add a suboption for it? It is too late for 2024.02.1,
but I will revert the change for 2023.02.x and 2023.11.x so I can get
those released (and EOL'ed).
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-03-26 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 17:49 [Buildroot] [PATCH 1/1] package/libdrm: disable tests Fabrice Fontaine
2024-03-23 20:33 ` Arnout Vandecappelle via buildroot
2024-03-25 7:56 ` Peter Korsgaard
2024-03-26 15:01 ` Peter Korsgaard [this message]
[not found] ` <87frwd9gvf.fsf__26724.073598028$1711465329$gmane$org@48ers.dk>
2024-03-26 18:37 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frwd9gvf.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=arnout@mind.be \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox