From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2DF6C61DA4 for ; Mon, 6 Feb 2023 11:26:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 65CBD402A6; Mon, 6 Feb 2023 11:26:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 65CBD402A6 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k5PneosyDD5k; Mon, 6 Feb 2023 11:26:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id C16214029B; Mon, 6 Feb 2023 11:26:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C16214029B Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 563961BF397 for ; Mon, 6 Feb 2023 11:26:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2FF474027A for ; Mon, 6 Feb 2023 11:26:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2FF474027A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fnYS1pICayTe for ; Mon, 6 Feb 2023 11:26:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1114C4022B Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1114C4022B for ; Mon, 6 Feb 2023 11:26:34 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id E0CA320007; Mon, 6 Feb 2023 11:26:30 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1pOzdl-00Dq1N-Tg; Mon, 06 Feb 2023 12:26:29 +0100 From: Peter Korsgaard To: Ricardo Martincoski References: <20221127130739.1862398-1-ricardo.martincoski@gmail.com> <20221127130739.1862398-14-ricardo.martincoski@gmail.com> Date: Mon, 06 Feb 2023 12:26:29 +0100 In-Reply-To: <20221127130739.1862398-14-ricardo.martincoski@gmail.com> (Ricardo Martincoski's message of "Sun, 27 Nov 2022 10:07:27 -0300") Message-ID: <87fsbjavbu.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [next 13/25] toolchain/toolchain-buildroot: add comment about using virtual package infra X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E . MORIN" , Thomas Petazzoni , buildroot@buildroot.org, Romain Naour , Giulio Benetti , Thomas De Schampheleire Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Ricardo" == Ricardo Martincoski writes: > Commit "9a8ec9195c toolchain/toolchain-buildroot: migrate to virtual > package infrastructure" made the packages toolchain and > toolchain-buildroot to use the virtual package infra even they being > generic packages. > This works because on package/pkg-virtual.mk when a package do not > define neither _PROVIDES_ or _HAS_ symbols, only _IS_VIRTUAL is set to > YES and _VERSION and _SOURCE are set to empty before relaying the call > to inner-generic-package. > Add a comment explaining why the virtual package infra is used in these > cases. > Cc: Giulio Benetti > Cc: Romain Naour > Cc: Thomas De Schampheleire > Cc: Thomas Petazzoni > Cc: Yann E. MORIN > Signed-off-by: Ricardo Martincoski Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot