From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B31AAC3DA7D for ; Sun, 1 Jan 2023 18:35:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 476C440629; Sun, 1 Jan 2023 18:35:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 476C440629 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tPlPqSdF5uB7; Sun, 1 Jan 2023 18:35:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 56AD94050F; Sun, 1 Jan 2023 18:35:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 56AD94050F Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 99E5B1BF41A for ; Sun, 1 Jan 2023 18:35:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 75A6981066 for ; Sun, 1 Jan 2023 18:35:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 75A6981066 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5JifIhnMz0mm for ; Sun, 1 Jan 2023 18:35:25 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 50FDB81026 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by smtp1.osuosl.org (Postfix) with ESMTPS id 50FDB81026 for ; Sun, 1 Jan 2023 18:35:25 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 538A81BF204; Sun, 1 Jan 2023 18:35:22 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1pC3B3-000mU6-6Z; Sun, 01 Jan 2023 19:35:21 +0100 From: Peter Korsgaard To: Thomas Petazzoni via buildroot References: <20221227204552.E6F4286EA0@busybox.osuosl.org> Date: Sun, 01 Jan 2023 19:35:21 +0100 In-Reply-To: <20221227204552.E6F4286EA0@busybox.osuosl.org> (Thomas Petazzoni via buildroot's message of "Tue, 27 Dec 2022 21:40:31 +0100") Message-ID: <87fscucdcm.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [git commit] support/tests: print failed command and output on assertRunOK error X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Thomas" == Thomas Petazzoni via buildroot writes: > commit: https://git.buildroot.net/buildroot/commit/?id=44161560dd52ebe9a41ee6e5ec8cacb2a9fe48ec > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master > Currently, when asserting that a command succeeded, we just capture the > return code of the command. If that is not zero, the assertion fails, > but the error message is not very splicit: > AssertionError: 1 != 0 > Replace the error message with an explicit message that dumps the failed > command, the error code, and the resulting output. > Signed-off-by: Yann E. MORIN > Cc: Thomas Petazzoni > Signed-off-by: Thomas Petazzoni Committed to 2022.11.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot