From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C737ECAAD8 for ; Wed, 14 Sep 2022 09:47:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 41A0C4175E; Wed, 14 Sep 2022 09:47:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 41A0C4175E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RyxEu-5-ZwoS; Wed, 14 Sep 2022 09:47:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 4455B41756; Wed, 14 Sep 2022 09:46:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4455B41756 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 480AA1BF355 for ; Wed, 14 Sep 2022 09:46:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2AA4560BBC for ; Wed, 14 Sep 2022 09:46:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2AA4560BBC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bWvbz1yMKLRI for ; Wed, 14 Sep 2022 09:46:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2FFE160757 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2FFE160757 for ; Wed, 14 Sep 2022 09:46:55 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id ED76C1C0007; Wed, 14 Sep 2022 09:46:52 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1oYOyp-0047dC-QE; Wed, 14 Sep 2022 11:46:51 +0200 From: Peter Korsgaard To: Thomas Petazzoni via buildroot References: <20220804203555.29029-1-thomas.petazzoni@bootlin.com> Date: Wed, 14 Sep 2022 11:46:51 +0200 In-Reply-To: <20220804203555.29029-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Thu, 4 Aug 2022 22:35:53 +0200") Message-ID: <87fsguqodw.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Ruschival , Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Thomas" == Thomas Petazzoni via buildroot writes: > rapidjson has been added as a dependency of pistache as part of commit > 2f3218567953185008ec862f814bebecb9d6ed82 ("package/pistache: bump > version & switch to meson build"), using a "depends on". However, as > it is a library dependency, a "select" is normally used in Buildroot. > rapidjson's only dependency is on C++ support, which is already a > dependency of pistache. > In addition, use = instead of += for the rapidjson dependency in the > .mk file, as it's an unconditional dependency. > Cc: Thomas Ruschival > Cc: Arnout Vandecappelle (Essensium/Mind) > Signed-off-by: Thomas Petazzoni Committed to 2022.05.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot