From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83868C6FA82 for ; Tue, 13 Sep 2022 14:35:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 295A840A87; Tue, 13 Sep 2022 14:35:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 295A840A87 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4axy3LTvp0BT; Tue, 13 Sep 2022 14:35:25 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 4BFC840A8F; Tue, 13 Sep 2022 14:35:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4BFC840A8F Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id C3EF41BF2F3 for ; Tue, 13 Sep 2022 14:35:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9B92D40A87 for ; Tue, 13 Sep 2022 14:35:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9B92D40A87 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z3NChnetpfVJ for ; Tue, 13 Sep 2022 14:35:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 88A16401CA Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp2.osuosl.org (Postfix) with ESMTPS id 88A16401CA for ; Tue, 13 Sep 2022 14:35:20 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 3764DE000A; Tue, 13 Sep 2022 14:35:16 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1oY70N-003PSy-VM; Tue, 13 Sep 2022 16:35:15 +0200 From: Peter Korsgaard To: "Arnout Vandecappelle (Essensium/Mind)" References: <20220729210444.1787668-1-arnout@mind.be> Date: Tue, 13 Sep 2022 16:35:15 +0200 In-Reply-To: <20220729210444.1787668-1-arnout@mind.be> (Arnout Vandecappelle's message of "Fri, 29 Jul 2022 23:04:44 +0200") Message-ID: <87fsgvtk9o.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] boot/arm-trusted-firmware: set CFLAGS from environment, not override X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kory Maincent , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) writes: > Older versions of TF-A don't support setting CFLAGS on the make command > line. They use 'CFLAGS += ...' in the Makefile, which is still > overridden by the CFLAGS on the command line. > Fix this by moving the CFLAGS setting to the environment. Both older and > newer versions of TF-A handle this correctly. > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/2781800954 > and a large number of other defconfigs > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) > Cc: Kory Maincent > --- > v2: updated commit message to show that it's fine for new versions as > well. Committed to 2022.05.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot