From: Peter Korsgaard <peter@korsgaard.com>
To: "Arnout Vandecappelle \(Essensium\/Mind\)" <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] treewide: fix flake8 error E741 ambiguous variable name
Date: Mon, 25 Oct 2021 14:12:22 +0200 [thread overview]
Message-ID: <87fsspwbfd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211018195822.2263226-2-arnout@mind.be> (Arnout Vandecappelle's message of "Mon, 18 Oct 2021 21:58:22 +0200")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> A recent update of flake8 in CI introduced a new check E741. It
> basically checks that variables are at least 3 characters long. Up to
> now, however, we have used shorter names in some places - all of them
> turn out to be "l" for a line of text.
> Replace all those "l" variables with "line".
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829
NIT: This is not about requiring >= 3 char variables, it is specifically
about the variables I, O and l as they may look very similar to the
numbers 0/1, depending on the font:
https://www.flake8rules.com/rules/E741.html
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-25 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:58 [Buildroot] [PATCH 1/2] tests: sample_python_dbus_next: ignore F821 flake8 error Arnout Vandecappelle (Essensium/Mind)
2021-10-18 19:58 ` [Buildroot] [PATCH 2/2] treewide: fix flake8 error E741 ambiguous variable name Arnout Vandecappelle (Essensium/Mind)
2021-10-18 20:34 ` Yann E. MORIN
2021-10-25 12:12 ` Peter Korsgaard [this message]
2021-10-18 20:33 ` [Buildroot] [PATCH 1/2] tests: sample_python_dbus_next: ignore F821 flake8 error Yann E. MORIN
2021-10-25 12:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsspwbfd.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox