From: Peter Korsgaard <peter@korsgaard.com>
To: Adrian Perez de Castro <aperez@igalia.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies
Date: Wed, 06 Oct 2021 17:18:01 +0200 [thread overview]
Message-ID: <87fste5gie.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211001103417.1078082-1-aperez@igalia.com> (Adrian Perez de Castro's message of "Fri, 1 Oct 2021 13:34:17 +0300")
>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:
> This is only a runtime dependency, not a build dependency.
> Based on a similar patch by James Hilliard for the wpewebkit
> package.
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/webkitgtk.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 6687d7f61b..87aeffea45 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -46,7 +46,7 @@ ifeq ($(BR2_PACKAGE_WEBKITGTK_MULTIMEDIA),y)
> WEBKITGTK_CONF_OPTS += \
> -DENABLE_VIDEO=ON \
> -DENABLE_WEB_AUDIO=ON
> -WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> +WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base
NIT: we normally add a # runtime comment to the select line in Config.in
then to make it clear why it isn't listed in _DEPENDENCIES.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-06 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 10:34 [Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies Adrian Perez de Castro
2021-10-03 20:15 ` Yann E. MORIN
2021-10-06 15:18 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fste5gie.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox