From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Kory Maincent <kory.maincent@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] fs/ext2: fix namespace for variables
Date: Tue, 05 Oct 2021 18:57:03 +0200 [thread overview]
Message-ID: <87fstfbeao.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211005152734.GA2081069@scaer> (Yann E. MORIN's message of "Tue, 5 Oct 2021 17:27:34 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Peter
> On 2021-10-05 15:43 +0200, Peter Korsgaard spake thusly:
>> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>> > In filesystems, variables must be prefixed with ROOTFS_, to avoid
>> > ckashing with packages of the same name.
> ^^^^^^^^
>> > We do not have a package named 'ext2', so we currently have no clash,
>> > but it is still ebtter that the variables be properly namespaced.
>> s/ebtter/better/ ;)
> Lol. But you missed s/ckashing/clashing/ above. ;-)
Grr, indeed ;)
>> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>> > Cc: Kory Maincent <kory.maincent@bootlin.com>
>> Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.
> Thanks for the backports! :-)
You're welcome!
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-05 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 20:19 [Buildroot] [PATCH] fs/ext2: fix namespace for variables Yann E. MORIN
2021-10-05 13:43 ` Peter Korsgaard
2021-10-05 15:27 ` Yann E. MORIN
2021-10-05 16:57 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fstfbeao.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox