Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/imagemagick: disable opencl
Date: Sat, 07 Mar 2020 22:06:25 +0100	[thread overview]
Message-ID: <87ftejx4by.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <874kw73bhp.fsf@dell.be.48ers.dk> (Peter Korsgaard's message of "Mon, 03 Feb 2020 17:02:26 +0100")

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
 >> On Fri, 23 Aug 2019 21:14:17 +0200
 >> Julien Olivain <juju@cotds.org> wrote:

 >>> Some packages installs libOpenCL without declaring
 >>> BR2_PACKAGE_PROVIDES_LIBOPENCL (e.g. imx-gpu-viv). ImageMagick will
 >>> detect the library and will require libtool. Since libtool is not in
 >>> dependencies, build might fail.
 >>> 
 >>> To prevent that situation, this patch explicitly disable opencl
 >>> support.
 >>> 
 >>> Signed-off-by: Julien Olivain <juju@cotds.org>

 >> FYI, I've started looking into this. First, there is an upstream commit
 >> that fixes using disable_opencl instead of enable_opencl. Then I fixed
 >> up the configure.ac to use the "no_cl" variable that the OpenCL M4
 >> macro defines. But then even with --disable-opencl, the build fails
 >> because MAGICKCORE__OPENCL is defined. I'm still trying to figure out
 >> why.

 > I don't see that issue any more (In fact, the only references to that
 > symbol seems to be in Magick{Core,Wand}/studio.h), and the
 > IMAGEMAGICK_CONV_ENV tweak isn't needed any more, so I dropped that and
 > committed - Thanks.

Committed to 2019.02.x and 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2020-03-07 21:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 19:14 [Buildroot] [PATCH 1/1] package/imagemagick: disable opencl Julien Olivain
2019-08-25  7:04 ` Peter Korsgaard
2019-08-25 10:47   ` juju at cotds.org
2019-09-24  9:47 ` Thomas Petazzoni
2020-02-03 16:02   ` Peter Korsgaard
2020-03-07 21:06     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftejx4by.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox