Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/gettext-tiny: fix install failure if path contains "m4/" string
Date: Thu, 05 Mar 2020 21:16:11 +0100	[thread overview]
Message-ID: <87ftema778.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200118220611.38913-1-giulio.benetti@benettiengineering.com> (Giulio Benetti's message of "Sat, 18 Jan 2020 23:06:11 +0100")

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > When building with path containing "m4/" occurence(i.e. make
 > O=output-m4) gettext-tiny install recipe copies files to wrong place and
 > later some package using autotools fail to autoreconf(i.e. minicom).
 > This is due to buggy gettext-tiny Makefile install recipe where they
 > substitute every "m4/" in INSTALL destination path, including the "m4/"
 > part of our build folder. Add patch to fix this by using $(patsubst ...)
 > instead of $(subst m4/,,$@) to substitute only last "m4/" occurence in
 > path.

 > Fixes:
 > https://bugs.busybox.net/show_bug.cgi?id=12481

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > ---
 > Pending upstream:
 > https://github.com/sabotage-linux/gettext-tiny/pull/49

 > V1-> V2:
 > * used $(patsubst ...) instead of sed as suggested by Heiko and xhebox

Committed to 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2020-03-05 20:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 17:53 [Buildroot] [PATCH] package/gettext-tiny: fix install failure if path contains "m4/" string Giulio Benetti
2020-01-17 17:55 ` Giulio Benetti
2020-01-17 20:29 ` Yann E. MORIN
2020-01-18 22:06   ` [Buildroot] [PATCH v2] " Giulio Benetti
2020-01-18 22:21     ` Yann E. MORIN
2020-03-05 20:16     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftema778.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox