From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/libcurl: rename curl binary config symbol
Date: Sun, 16 Feb 2020 11:28:33 +0100 [thread overview]
Message-ID: <87ftfaj06m.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <c26bb4f7c24adf02f3260fafaa70536472d255e3.1581336419.git.baruch@tkos.co.il> (Baruch Siach's message of "Mon, 10 Feb 2020 14:06:59 +0200")
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Package optional or choice config symbols are usually prefixed with the
> package config symbol name. Rename BR2_PACKAGE_CURL to
> BR2_PACKAGE_LIBCURL_CURL to conform.
> Update references to the old name.
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v2:
> Rebase on current master:
> * Move legacy entry to 2020.02
> * Handle glslsandbox-player select
I'm personally not super thrilled about the breakage in various custom
configs, but OK - It is indeed "odd" to have a suboption not prefixed
with _LIBCURL and nobody gave any negative feedback - So committed,
thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-02-16 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 12:06 [Buildroot] [PATCH v2] package/libcurl: rename curl binary config symbol Baruch Siach
2020-02-10 13:53 ` Matthew Weber
2020-02-10 16:36 ` Baruch Siach
2020-02-16 10:28 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftfaj06m.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox