Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/giflib: security bump to version 5.2.1
Date: Mon, 19 Aug 2019 19:07:24 +0200	[thread overview]
Message-ID: <87ftlxgk37.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190819154603.51a042a2@windsurf.home> (Thomas Petazzoni's message of "Mon, 19 Aug 2019 15:46:03 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Sun, 18 Aug 2019 14:04:32 +0200
 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

 >> - Switch to generic-package (autotools has been dropped since version
 >> 5.1.5)
 >> - Remove hook and instead use dedicated makefile targets to build only
 >> shared or static library and not binaries or documentation (added by
 >> an upstreamble patch)
 >> - ac_cv_prog_have_xmlto=no can be removed as doc is not built anymore
 >> - Fix CVE-2018-11490: The DGifDecompressLine function in dgif_lib.c in
 >> GIFLIB (possibly version 3.0.x), as later shipped in cgif.c in sam2p
 >> 0.49.4, has a heap-based buffer overflow because a certain
 >> "Private->RunningCode - 2" array index is not checked. This will lead
 >> to a denial of service or possibly unspecified other impact.
 >> - Fix CVE-2019-15133: In GIFLIB before 2019-02-16, a malformed GIF file
 >> triggers a divide-by-zero exception in the decoder function DGifSlurp
 >> in dgif_lib.c if the height field of the ImageSize data structure is
 >> equal to zero.
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> ...dd-targets-to-manage-static-building.patch | 69 +++++++++++++++++++
 >> package/giflib/giflib.hash                    |  4 +-
 >> package/giflib/giflib.mk                      | 47 +++++++++----
 >> 3 files changed, 104 insertions(+), 16 deletions(-)
 >> create mode 100644 package/giflib/0001-Makefile-add-targets-to-manage-static-building.patch

 > I must say this is quite big of a change for master at this point, and
 > for a security bump in general. I'm not sure between applying this, or
 > just cherry-picking the two commits that fix the CVEs.

Yes, I believe that is also what we agreed when Bernd posted a similar
patch last month:

https://patchwork.ozlabs.org/patch/1124785/

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2019-08-19 17:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18 12:04 [Buildroot] [PATCH 1/1] package/giflib: security bump to version 5.2.1 Fabrice Fontaine
2019-08-19 13:46 ` Thomas Petazzoni
2019-08-19 13:57   ` Fabrice Fontaine
2019-08-19 20:57     ` Peter Korsgaard
2019-08-19 17:07   ` Peter Korsgaard [this message]
2019-08-19 19:40     ` Thomas Petazzoni
2019-08-19 20:26       ` Fabrice Fontaine
2019-08-19 20:58         ` Peter Korsgaard
2019-08-19 20:44       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftlxgk37.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox