Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/flare-engine: re-enable package on microblaze
Date: Thu, 06 Jun 2019 17:20:42 +0200	[thread overview]
Message-ID: <87ftomivud.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190527213701.2BAC18DAA9@busybox.osuosl.org> (Arnout Vandecappelle's message of "Mon, 27 May 2019 23:37:42 +0200")

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=1203cca1b51eefb4ee236d998ab6ec32bdd087d8
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > With Microblaze Gcc version < 8.x the build hangs due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > To avoid this, the flare-engine package has a
 > !BR2_TOOLCHAIN_HAS_GCC_BUG_85180 dependency. However, gcc bug 85180 only
 > triggers when optimization is enabled, so we can work around the issue
 > by passing -O0, which is what we do in other Buildroot packages to work
 > around this bug.

 > So, this commit passes -O0 when BR2_TOOLCHAIN_HAS_GCC_BUG_85180, and
 > re-enables flare-engine on Microblaze. It is not enough to set
 > CMAKE_CXX_FLAGS, because flare-engine's CMakeLists.txt sets
 > CMAKE_CXX_FLAGS_<BUILD_TYPE> (depending on the value of
 > CMAKE_BUILD_TYPE), and the build-type-specific flags come after the
 > generic flags, so our -O0 gets overridden again. Therefore, also set
 > CMAKE_BUILD_TYPE to the dummy value Buildroot.

 > Fixes:
 > http://autobuild.buildroot.net/results/706/7065e14917a8bbc0faf21b29183ac55b6c800ee3/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
 > [Arnout: extend explanatory comment and update commit log]
 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2019-06-06 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 21:37 [Buildroot] [git commit] package/flare-engine: re-enable package on microblaze Arnout Vandecappelle
2019-05-27 21:50 ` Giulio Benetti
2019-05-27 22:02   ` Arnout Vandecappelle
2019-06-06 15:20 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftomivud.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox