From mboxrd@z Thu Jan 1 00:00:00 1970 From: Esben Haabendal Date: Wed, 27 Mar 2019 23:28:29 +0100 Subject: [Buildroot] [PATCH] gummiboot: fix linking for non-host compatible targets In-Reply-To: (Arnout Vandecappelle's message of "Tue, 26 Mar 2019 21:33:39 +0100") References: <20190326130757.4521-1-esben.haabendal@gmail.com> Message-ID: <87ftr89cky.fsf@haabendal.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout Vandecappelle writes: > On 26/03/2019 14:07, Esben Haabendal wrote: >> + $(gummiboot_solib): $(gummiboot_objects) >> +- $(AM_V_CCLD)$(LD) $(efi_ldflags) $(gummiboot_objects) \ >> ++ $(AM_V_CCLD)$(EFI_LD) $(efi_ldflags) $(gummiboot_objects) \ >> + -o $@ -lefi -lgnuefi $(shell $(CC) -print-libgcc-file-name); \ > ^^^^ Shouldn't this be EFI_CC? Yes, it probably should. >> + nm -D -u $@ | grep ' U ' && exit 1 || : > > Is nm the same on all architectures? I assume nm is cross, so no. > Of course, since gummiboot is x86 only, it doesn't matter much. I can include support for specifying $(NM) also, but as you say, it might not make a difference for anybody. Unless, someone builds x86 images on non-x86 platforms. /Esben