From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
Date: Mon, 17 Dec 2018 23:48:34 +0100 [thread overview]
Message-ID: <87ftuv3h31.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181217084710.16192-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Mon, 17 Dec 2018 09:47:10 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> The netsurf build system creates a stamp file inside TMP_PREFIX to
> know if the build was done, and if the stamp file exists, it doesn't
> do any build. Therefore, having this stamp file in STAGING_DIR
> prevents from rebuilding netsurf, even after removing its entire build
> directory: the stamp file exists in STAGING_DIR, and netsurf doesn't
> build anything, causing the installation to fail.
> We fix this by putting this temporary directory inside the netsurf
> build directory.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/netsurf/netsurf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> index e5a251b9c1..e4ed4fd1a7 100644
> --- a/package/netsurf/netsurf.mk
> +++ b/package/netsurf/netsurf.mk
> @@ -78,7 +78,7 @@ NETSURF_MAKE_OPTS = \
> BUILD_CC="$(HOSTCC)" \
> CC="$(TARGET_CC)" \
> AR="$(TARGET_AR)" \
> - TMP_PREFIX=$(STAGING_DIR)/usr \
> + TMP_PREFIX=$(@D)/tmpusr \
Why do we have to set it at all? It looks like it defaults to a
directory under the build dir as well?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-12-17 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 8:47 [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory Thomas Petazzoni
2018-12-17 22:48 ` Peter Korsgaard [this message]
2018-12-18 7:18 ` François Perrad
2018-12-18 7:48 ` Thomas Petazzoni
2019-02-03 20:36 ` Arnout Vandecappelle
2019-02-04 10:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftuv3h31.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox