Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 3/4] BR2_FORTIFY*: toolchain wrapper limitation note
Date: Sat, 20 Oct 2018 13:21:37 +0200	[thread overview]
Message-ID: <87ftx0euda.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1537219312-59962-4-git-send-email-matthew.weber@rockwellcollins.com> (Matt Weber's message of "Mon, 17 Sep 2018 16:21:51 -0500")

>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > A note is added to tie off the discussion on why moving _FORTIFY_SOURCE
 > related flags into the toolchain wrapper doesn't currently work.

 >  - Currently -D_FORTIFY_SOURCE and optimizations are passed through
 >    CFLAGS

 >  - Packages like linux-tools ignore CFLAGS entirely and some
 >    autotools toolchain testing cases dependent on not using
 >    CFLAGS.

 >  - If FORTIFY_SOURCE is passed through the wrapper, then linux-tools
 >    will no longer be able to ignore it, because it's enforced at a
 >    lower-level and since the optimization -Os/g/1/2/3 are via CFLAGS,
 >    there is no optimization flag set.  Therefore linux-tools will do
 >    all its configuration tests with FORTIFY_SOURCE forcefully enabled
 >    at the wrapper level, but no optimization enabled, and consequently
 >    tests will fail.

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-10-20 11:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 21:21 [Buildroot] [PATCH v7 0/4] Hardening Wrapper Updates and Test Matt Weber
2018-09-17 21:21 ` [Buildroot] [PATCH v7 1/4] toolchain/toolchain-wrapper: add BR2_RELRO_ Matt Weber
2018-10-20 10:49   ` Peter Korsgaard
2018-09-17 21:21 ` [Buildroot] [PATCH v7 2/4] toolchain/toolchain-wrapper: add BR2_SSP_* support Matt Weber
2018-10-20 10:53   ` Peter Korsgaard
2018-09-17 21:21 ` [Buildroot] [PATCH v7 3/4] BR2_FORTIFY*: toolchain wrapper limitation note Matt Weber
2018-10-20 11:21   ` Peter Korsgaard [this message]
2018-09-17 21:21 ` [Buildroot] [PATCH v7 4/4] support/testing/tests/core: SSP & hardening flags Matt Weber
2018-10-20 11:26   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftx0euda.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox