Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] package/transmission: fix systemd support
Date: Mon, 11 Jun 2018 23:15:01 +0200	[thread overview]
Message-ID: <87fu1t9ga2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180520153155.1af6c039@windsurf> (Thomas Petazzoni's message of "Sun, 20 May 2018 15:31:55 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Wed,  2 May 2018 08:05:38 +0200, Bernd Kuhls wrote:
 >> Patch 0005-libsystemd.patch backports an upstream commit which renames
 >> the systemd configure option.
 >> 
 >> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 >> ---
 >> package/transmission/transmission.mk | 4 ++--
 >> 1 file changed, 2 insertions(+), 2 deletions(-)

 > The order of the patches in your patch series is not very good. Indeed,
 > patches 2/4, 3/4 and 4/4 are fixing problems that exist *today* in
 > Buildroot, with the current version of transmission being packaged.
 > Therefore, they should appear first in the series, before the bump.

 > This is even more relevant right now, as patches 2/4, 3/4 and 4/4
 > should be applied to master, while patch 1/4 is only for next.

 > So, I've applied this patch to master, after fixing the commit log to
 > mention 0006-libsystemd.patch, since the patch is named this way in
 > master.

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-06-11 21:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  6:05 [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Bernd Kuhls
2018-05-02  6:05 ` [Buildroot] [PATCH 2/4] package/transmission: fix systemd support Bernd Kuhls
2018-05-20 13:31   ` Thomas Petazzoni
2018-06-11 21:15     ` Peter Korsgaard [this message]
2018-05-02  6:05 ` [Buildroot] [PATCH 3/4] package/transmission: fix inotify configure option Bernd Kuhls
2018-05-20 13:37   ` Thomas Petazzoni
2018-06-11 21:15     ` Peter Korsgaard
2018-05-02  6:05 ` [Buildroot] [PATCH 4/4] package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE Bernd Kuhls
2018-05-20 13:48   ` Thomas Petazzoni
2018-05-20 13:49 ` [Buildroot] [PATCH 1/4] package/transmission: bump version to 2.9.4 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu1t9ga2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox