* [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0
@ 2017-04-27 1:02 Matt Weber
2017-04-27 8:17 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Matt Weber @ 2017-04-27 1:02 UTC (permalink / raw)
To: buildroot
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
package/libqmi/libqmi.hash | 2 +-
package/libqmi/libqmi.mk | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/libqmi/libqmi.hash b/package/libqmi/libqmi.hash
index 08da1ae..3f40154 100644
--- a/package/libqmi/libqmi.hash
+++ b/package/libqmi/libqmi.hash
@@ -1,2 +1,2 @@
# Locally computed:
-sha256 7ab6bb47fd23bf4d3fa17424e40ea5552d08b19e5ee4f125f21f316c8086ba2a libqmi-1.16.0.tar.xz
+sha256 a0a42c55935e75a630208e2f70840bd4407f56fe1c5258f5b0f6c0aaedf88cec libqmi-1.18.0.tar.xz
diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
index caa4398..92b635d 100644
--- a/package/libqmi/libqmi.mk
+++ b/package/libqmi/libqmi.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBQMI_VERSION = 1.16.0
+LIBQMI_VERSION = 1.18.0
LIBQMI_SITE = http://www.freedesktop.org/software/libqmi
LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.xz
LIBQMI_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)
@@ -13,7 +13,7 @@ LIBQMI_INSTALL_STAGING = YES
LIBQMI_DEPENDENCIES = libglib2
-# we don't want -Werror
-LIBQMI_CONF_OPTS = --enable-more-warnings=no
+# we don't want -Werror and disable gudev Gobject bindings
+LIBQMI_CONF_OPTS = --enable-more-warnings=no --without-udev
$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0
2017-04-27 1:02 [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0 Matt Weber
@ 2017-04-27 8:17 ` Peter Korsgaard
2017-04-27 11:18 ` Matthew Weber
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2017-04-27 8:17 UTC (permalink / raw)
To: buildroot
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> package/libqmi/libqmi.hash | 2 +-
> package/libqmi/libqmi.mk | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
> diff --git a/package/libqmi/libqmi.hash b/package/libqmi/libqmi.hash
> index 08da1ae..3f40154 100644
> --- a/package/libqmi/libqmi.hash
> +++ b/package/libqmi/libqmi.hash
> @@ -1,2 +1,2 @@
> # Locally computed:
> -sha256 7ab6bb47fd23bf4d3fa17424e40ea5552d08b19e5ee4f125f21f316c8086ba2a libqmi-1.16.0.tar.xz
> +sha256 a0a42c55935e75a630208e2f70840bd4407f56fe1c5258f5b0f6c0aaedf88cec libqmi-1.18.0.tar.xz
> diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
> index caa4398..92b635d 100644
> --- a/package/libqmi/libqmi.mk
> +++ b/package/libqmi/libqmi.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
> -LIBQMI_VERSION = 1.16.0
> +LIBQMI_VERSION = 1.18.0
> LIBQMI_SITE = http://www.freedesktop.org/software/libqmi
> LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.xz
> LIBQMI_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)
> @@ -13,7 +13,7 @@ LIBQMI_INSTALL_STAGING = YES
> LIBQMI_DEPENDENCIES = libglib2
> -# we don't want -Werror
> -LIBQMI_CONF_OPTS = --enable-more-warnings=no
> +# we don't want -Werror and disable gudev Gobject bindings
Why? It would be good to describe why we don't want udev support.
> +LIBQMI_CONF_OPTS = --enable-more-warnings=no --without-udev
> $(eval $(autotools-package))
> --
> 1.9.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0
2017-04-27 8:17 ` Peter Korsgaard
@ 2017-04-27 11:18 ` Matthew Weber
2017-04-27 11:44 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Weber @ 2017-04-27 11:18 UTC (permalink / raw)
To: buildroot
Peter,
On Thu, Apr 27, 2017 at 3:17 AM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:
>
> > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> > ---
> > package/libqmi/libqmi.hash | 2 +-
> > package/libqmi/libqmi.mk | 6 +++---
> > 2 files changed, 4 insertions(+), 4 deletions(-)
>
> > diff --git a/package/libqmi/libqmi.hash b/package/libqmi/libqmi.hash
> > index 08da1ae..3f40154 100644
> > --- a/package/libqmi/libqmi.hash
> > +++ b/package/libqmi/libqmi.hash
> > @@ -1,2 +1,2 @@
> > # Locally computed:
> > -sha256 7ab6bb47fd23bf4d3fa17424e40ea5552d08b19e5ee4f125f21f316c8086ba2a libqmi-1.16.0.tar.xz
> > +sha256 a0a42c55935e75a630208e2f70840bd4407f56fe1c5258f5b0f6c0aaedf88cec libqmi-1.18.0.tar.xz
> > diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk
> > index caa4398..92b635d 100644
> > --- a/package/libqmi/libqmi.mk
> > +++ b/package/libqmi/libqmi.mk
> > @@ -4,7 +4,7 @@
> > #
> > ################################################################################
>
> > -LIBQMI_VERSION = 1.16.0
> > +LIBQMI_VERSION = 1.18.0
> > LIBQMI_SITE = http://www.freedesktop.org/software/libqmi
> > LIBQMI_SOURCE = libqmi-$(LIBQMI_VERSION).tar.xz
> > LIBQMI_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)
> > @@ -13,7 +13,7 @@ LIBQMI_INSTALL_STAGING = YES
>
> > LIBQMI_DEPENDENCIES = libglib2
>
> > -# we don't want -Werror
> > -LIBQMI_CONF_OPTS = --enable-more-warnings=no
> > +# we don't want -Werror and disable gudev Gobject bindings
>
> Why? It would be good to describe why we don't want udev support.
Sure, should I add more to the comment in the file or patch submission
that the gudev package currently isn't part of buildroot to provide
the Gobject bindings between libqmi and eudev?
Matt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0
2017-04-27 11:18 ` Matthew Weber
@ 2017-04-27 11:44 ` Peter Korsgaard
2017-04-27 12:53 ` Matthew Weber
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2017-04-27 11:44 UTC (permalink / raw)
To: buildroot
>>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes:
Hi,
>> > -# we don't want -Werror
>> > -LIBQMI_CONF_OPTS = --enable-more-warnings=no
>> > +# we don't want -Werror and disable gudev Gobject bindings
>>
>> Why? It would be good to describe why we don't want udev support.
> Sure, should I add more to the comment in the file or patch submission
> that the gudev package currently isn't part of buildroot to provide
> the Gobject bindings between libqmi and eudev?
Just adding it in the patch description is fine, thanks!
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0
2017-04-27 11:44 ` Peter Korsgaard
@ 2017-04-27 12:53 ` Matthew Weber
0 siblings, 0 replies; 5+ messages in thread
From: Matthew Weber @ 2017-04-27 12:53 UTC (permalink / raw)
To: buildroot
Peter,
On Thu, Apr 27, 2017 at 6:44 AM, Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes:
>
> Hi,
>
> >> > -# we don't want -Werror
> >> > -LIBQMI_CONF_OPTS = --enable-more-warnings=no
> >> > +# we don't want -Werror and disable gudev Gobject bindings
> >>
> >> Why? It would be good to describe why we don't want udev support.
>
>
> > Sure, should I add more to the comment in the file or patch submission
> > that the gudev package currently isn't part of buildroot to provide
> > the Gobject bindings between libqmi and eudev?
>
> Just adding it in the patch description is fine, thanks!
>
https://patchwork.ozlabs.org/patch/756021/
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-27 12:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-27 1:02 [Buildroot] [PATCH 1/1] package/libqmi: bump version to 1.18.0 Matt Weber
2017-04-27 8:17 ` Peter Korsgaard
2017-04-27 11:18 ` Matthew Weber
2017-04-27 11:44 ` Peter Korsgaard
2017-04-27 12:53 ` Matthew Weber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox