Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kmod: workaround for microblaze ld bug
Date: Sun, 19 Feb 2017 22:27:06 +0100	[thread overview]
Message-ID: <87fuj9swgl.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170218214054.GA361@waldemar-brodkorb.de> (Waldemar Brodkorb's message of "Sat, 18 Feb 2017 22:40:54 +0100")

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > Add a workaround for a microblaze specific ld bug to avoid
 > segfault.

 > Fixes:
 >   http://autobuild.buildroot.net/results/aef1b915ffd3e5678af8682727c22c5618edfd89

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
 > ---
 >  package/kmod/kmod.mk | 10 ++++++++++
 >  1 file changed, 10 insertions(+)

 > diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
 > index 7492b92..2524bcd 100644
 > --- a/package/kmod/kmod.mk
 > +++ b/package/kmod/kmod.mk
 > @@ -15,6 +15,16 @@ HOST_KMOD_DEPENDENCIES = host-pkgconf
 >  KMOD_LICENSE = LGPLv2.1+ (library)
 >  KMOD_LICENSE_FILES = libkmod/COPYING
 
 > +# --gc-sections triggers binutils ld segfault
 > +# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
 > +ifeq ($(BR2_microblaze),y)
 > +define KMOD_PRECONFIGURE
 > +	sed -i 's:-Wl,--gc-sections::g' $(@D)/configure

Patching the generated configure script is quite icky. We can just tell
the configure script that --gc-sections aren't supported, so I've
changed it to do:

KMOD_CONF_ENV += cc_cv_LDFLAGS__Wl___gc_sections=false

And committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-02-19 21:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 21:40 [Buildroot] [PATCH] kmod: workaround for microblaze ld bug Waldemar Brodkorb
2017-02-19 21:27 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuj9swgl.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox