Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/6] xorg: fix imput drivers install paths
Date: Tue, 25 Oct 2016 13:25:54 +0200	[thread overview]
Message-ID: <87funkllfh.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <cover.1477327063.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Mon, 24 Oct 2016 18:38:49 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Hello All!
 > This series fixes the install paths of the few remaining input drivers
 > that incorrectly installed headers in $(TARGET_DIR)/$(STAGING_DIR).

 > The underlying issue is that xorg defines an "sdkdir" pkg-config
 > variable, as the location to find/install headers. This location is an
 > absolute path to the staging dir (aka sysroot), but headers are
 > installed in $(DESTDIR)/$(sdkdir).

 > We fix that by entirely ditching the use of sdkdir, as was done in all
 > other xorg dirvers, with the 5 first patches of the series.

Sounds sensible to me. Did you try proposing the patches upstream?

 > Additionally, to catch such situation, the 6th and last patch of the
 > series checks no such paths are present, neither in target/ nor in
 > staging/ .

This seems to overlap with the checks Samuel is adding,
E.G. TARGET_DIR/STAGING_DIR are subdirs of the host build directory, so
that check should catch these issues as well.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2016-10-25 11:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 16:38 [Buildroot] [PATCH 0/6] xorg: fix imput drivers install paths Yann E. MORIN
2016-10-24 16:38 ` [Buildroot] [PATCH 1/6] package/xdriver_xf86-input-evdev: fix " Yann E. MORIN
2016-10-24 16:38 ` [Buildroot] [PATCH 2/6] package/xdriver_xf86-input-joystick: " Yann E. MORIN
2016-10-24 16:38 ` [Buildroot] [PATCH 3/6] package/xdriver_xf86-input-libinput: " Yann E. MORIN
2016-10-24 16:38 ` [Buildroot] [PATCH 4/6] package/xdriver_xf86-input-mouse: " Yann E. MORIN
2016-10-24 16:38 ` [Buildroot] [PATCH 5/6] package/xdriver_xf86-input-synaptics: " Yann E. MORIN
2016-10-24 16:38 ` [Buildroot] [PATCH 6/6] core/pkg-generic: check proper package installation Yann E. MORIN
2016-10-25 11:25 ` Peter Korsgaard [this message]
2016-10-25 11:39   ` [Buildroot] [PATCH 0/6] xorg: fix imput drivers install paths Thomas Petazzoni
2016-10-25 11:45     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87funkllfh.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox