From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 4/7] package/ffmpeg: default to --cpu=generic for MIPS architecture
Date: Sat, 02 Jul 2016 16:08:01 +0200 [thread overview]
Message-ID: <87furs6sla.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1467466339-19422-4-git-send-email-bernd.kuhls@t-online.de> (Bernd Kuhls's message of "Sat, 2 Jul 2016 15:32:16 +0200")
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> This option is needed to prevent this message from configure:
> WARNING: unknown CPU. Disabling all MIPS optimizations.
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v4: no changes
> v3: no changes
> v2: no changes
> package/ffmpeg/ffmpeg.mk | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index 08914b8..418893f 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -445,6 +445,11 @@ else ifneq ($(call qstrip,$(BR2_GCC_TARGET_ARCH)),)
> FFMPEG_CONF_OPTS += --cpu=$(BR2_GCC_TARGET_ARCH)
> endif
> +# Default to --cpu=generic for MIPS architecture
> +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
> +FFMPEG_CONF_OPTS += --cpu=generic
> +endif
This is not really about "defaulting" to it, as the logic really
enforces it. From looking at the upstream configure script passing this
means that we explicitly need to pass --enable/--disable for the MIPS
sub options:
https://github.com/FFmpeg/FFmpeg/blob/master/configure#L4406
> +
> FFMPEG_CONF_OPTS += $(call qstrip,$(BR2_PACKAGE_FFMPEG_EXTRACONF))
> # Override FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others
> --
> 2.8.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-07-02 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 13:32 [Buildroot] [PATCH v4 1/7] package/freerdp: add support for ffmpeg 3.0 Bernd Kuhls
2016-07-02 13:32 ` [Buildroot] [PATCH v4 2/7] package/ffmpeg: bump to version 3.1.1 Bernd Kuhls
2016-07-02 13:38 ` Thomas Petazzoni
2016-07-02 14:41 ` Bernd Kuhls
[not found] ` <E1bJM6V-0004mv-DY@fli4l.lan.fli4l>
2016-07-02 14:47 ` Thomas Petazzoni
2016-07-02 15:16 ` Bernd Kuhls
2016-07-02 13:32 ` [Buildroot] [PATCH v4 3/7] package/ffmpeg: cosmetic change for the mips fpu option Bernd Kuhls
2016-07-02 13:42 ` Peter Korsgaard
2016-07-02 13:32 ` [Buildroot] [PATCH v4 4/7] package/ffmpeg: default to --cpu=generic for MIPS architecture Bernd Kuhls
2016-07-02 14:08 ` Peter Korsgaard [this message]
2016-07-02 13:32 ` [Buildroot] [PATCH v4 5/7] package/ffmpeg: re-enable for mips64r2 and mips64r6 Bernd Kuhls
2016-07-02 13:32 ` [Buildroot] [PATCH v4 6/7] package/vlc: bump version to git master (to be released as 3.0) Bernd Kuhls
2016-07-02 13:32 ` [Buildroot] [PATCH v4 7/7] package/tvheadend: remove compat patch for ffmpeg < 3.x Bernd Kuhls
2016-07-02 13:39 ` [Buildroot] [PATCH v4 1/7] package/freerdp: add support for ffmpeg 3.0 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87furs6sla.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox