From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Sun, 13 Mar 2016 21:44:29 +0100 Subject: [Buildroot] [PATCH] slang: make install-static do install-pkgconfig In-Reply-To: <20160313202028.GA3488@free.fr> (Yann E. MORIN's message of "Sun, 13 Mar 2016 21:20:28 +0100") References: <1457838391-19605-1-git-send-email-jcmvbkbc@gmail.com> <87mvq2gmo4.fsf@dell.be.48ers.dk> <20160313202028.GA3488@free.fr> Message-ID: <87fuvuf6qa.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: Hi, >> Patch description and signed-off-by missing. Alternatively we can drop >> the patch and just pass install-pkgconfig to the 'make install' step as >> we already need to use a custom make target anyway. > That's what Max did in his first patch, and I asked him to do it in our > patch. > The .pc file is not installed for static-only because *we* added a patch > that breaks down install into install-staging and install-shared. But that patch is an upstream patch: Repository: git://git.jedsoft.org/git/slang.git Commit ID: 3796db6fb94a2fc7fe2fb0b6918501b69a4d3a02 Author: John E. Davis So just changing what the patch does without updating the comment is imho not the right way to go. We should instead add a 0003 patch and send it upstream. -- Venlig hilsen, Peter Korsgaard