From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] gst1-av: fix cpu detection in libav configure
Date: Mon, 29 Feb 2016 12:27:33 +0100 [thread overview]
Message-ID: <87fuwbpxi2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1456701407-18377-1-git-send-email-arnout@mind.be> (Arnout Vandecappelle's message of "Mon, 29 Feb 2016 00:16:47 +0100")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> The configure script tries to guess a lot based on the cpu for which it
> is configured. Without --cpu, it will use a 'generic' cpu and disable
> any other options we pass to it.
> In addition, we have to pass the --sysroot option like we do in the
> ffmpeg package. This makes sure that regardless of the architecture
> options that ffmpeg passes along, an external multilib toolchain
> doesn't try to use a subdirectory of the sysroot. The libav build
> system will pass a --isysroot argument which overrides the multilib
> subdir.
> Finally, we have to properly enable/disable the architecture-specific
> optimisations. Autodetection of these things is completely borked in
> the configure script.
> Fixes:
> http://autobuild.buildroot.net/results/ce83513135e7765c171353815947d715eb897d3d
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> v2: improve commit message
> The --isysroot is something we should probably do in the toolchain
> wrapper.
What is the advantage of --isysroot over --sysroot? I don't seem to find
a lot about in the gcc documentation, but it seems like:
- isysroot only applied to headers, not headers+libraries like --sysroot
- Some versions of MacOSX/llvm only support --isysroot, not --sysroot
Neither of these seems of much interest to us?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-02-29 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 23:16 [Buildroot] [PATCH v2] gst1-av: fix cpu detection in libav configure Arnout Vandecappelle
2016-02-29 11:27 ` Peter Korsgaard [this message]
2016-03-01 22:42 ` Arnout Vandecappelle
2016-02-29 21:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuwbpxi2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox