From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/dropbear: Respect user specific configurations
Date: Mon, 09 Nov 2015 23:14:02 +0100 [thread overview]
Message-ID: <87fv0estw5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20151103225311.22589f69@free-electrons.com> (Thomas Petazzoni's message of "Tue, 3 Nov 2015 22:53:11 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Gabe Evans,
> On Tue, 3 Nov 2015 13:17:05 -0800, Gabe Evans wrote:
>> This patch results in dropbear being broken out-of-the-box for systemd
>> users. The EnvironmentFile= line sets a requirement that
>> /etc/default/dropbear exist (it doesn't, by default).
>>
>> I'm not so sure having an environment file by default is a good practice
>> for systemd units. The general consensus is that things effecting the
>> execution of a service should always be found in the appropriate service
>> unit. Environment= would be better anyway since there's only one variable
>> ($DROPBEAR_ARGS) being used in this particular case.
> Right. I'll revert the patch from Cyril then, unless he suggests a
> better solution. I really don't know much about systemd, so I can only
> rely on people reviewing patches touching systemd topics. If no-one
> does, all I can do is a guess that the change looks somewhat reasonable.
I have instead changed it to use =- as suggested by Maxime and Steven
and fixed a similar issue with out dhcp package.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2015-11-09 22:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 6:11 [Buildroot] [PATCH 1/2] package/dropbear: Respect user specific configurations Cyril Bur
2015-10-29 6:11 ` [Buildroot] [PATCH 2/2] package/systemd: Respect BR2_TARGET_GENERIC_GETTY_BAUDRATE Cyril Bur
2015-10-29 6:17 ` Cyril Bur
2015-10-29 10:41 ` Martin Bark
2015-11-04 9:22 ` Maxime Hadjinlian
2015-11-13 1:08 ` Cyril Bur
2015-11-13 6:42 ` Arnout Vandecappelle
2015-11-06 8:41 ` Nicolas Cavallari
2015-11-05 12:32 ` Thomas Petazzoni
2015-11-13 0:57 ` Cyril Bur
2015-10-29 6:16 ` [Buildroot] [PATCH 1/2] package/dropbear: Respect user specific configurations Cyril Bur
2015-11-02 21:43 ` Thomas Petazzoni
2015-11-03 21:17 ` Gabe Evans
2015-11-03 21:53 ` Thomas Petazzoni
2015-11-03 22:21 ` Gabe Evans
2015-11-04 10:46 ` Maxime Hadjinlian
2015-11-04 18:34 ` Gabe Evans
2015-11-09 22:14 ` Peter Korsgaard [this message]
2015-11-04 18:38 ` Steven Noonan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv0estw5.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox