From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Makefile: Remove 'quiet' variable
Date: Thu, 29 Oct 2015 00:05:01 +0100 [thread overview]
Message-ID: <87fv0u61cy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1444334617-23796-1-git-send-email-cedric.marie@openmailbox.org> ("Cédric Marie"'s message of "Thu, 8 Oct 2015 22:03:37 +0200")
>>>>> "C?dric" == C?dric Marie <cedric.marie@openmailbox.org> writes:
> 'quiet' variable is set and exported, but it is not used. We can safely
> remove it.
> This variable is inherited from the Makefile of the Linux kernel, and
> is not used in Buildroot.
> In support/scripts/mkmakefile, 'quiet' value is checked, but the test
> is always true ('quiet' is never set to silent_), so the test can be
> removed as well.
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
> ---
> Changes v1 -> v2:
> - KBUILD_VERBOSE must not be removed, it is used for packages based
> on Kbuild.
> Title of PATCH v1 was:
> Makefile: Remove KBUILD_VERBOSE and quiet
> In order to describe how the verbosity level is managed in different
> infrastructures, comments will be added in Makefile (suggested by Arnout).
> It will be provided in a separate patch.
> Arnout also suggested not to export 'Q', which seems to be Buildroot
> internal. This will also be provided in a separate patch, if confirmed.
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2015-10-28 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 20:03 [Buildroot] [PATCH v2] Makefile: Remove 'quiet' variable Cédric Marie
2015-10-27 4:52 ` James Knight
2015-10-28 21:00 ` Arnout Vandecappelle
2015-10-28 23:05 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv0u61cy.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox