From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] syslog-ng: Specify location of libesmtp
Date: Wed, 21 Oct 2015 11:45:20 +0200 [thread overview]
Message-ID: <87fv14imhb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20151021102711.44de0ec5@free-electrons.com> (Thomas Petazzoni's message of "Wed, 21 Oct 2015 10:27:11 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Chris Packham,
> On Wed, 21 Oct 2015 20:41:54 +1300, Chris Packham wrote:
>> The way the test is implemented in configure.ac libestmp-config is
>> invoked directly so it would need to be on the path. Or I could look
>> at an upstream patch to change this to something that can be
>> overridden. I'd almost prefer if libesmtp had pkg-config support which
>> integrates better with autotools and buildroot has existing support
>> for.
> As Peter suggested, the way we usually fix that is by replacing the
> direct invocation of <foo>-config in configure.ac by
> ${FOO_CONFIG:foo-config}, so that it can be overridden in the
> environment.
> However, the current --with-<foo> solution that you have used is fine
> for me. We do use this solution for numerous packages, so I'm fine with
> using it as well for syslog-ng.
Agreed. The only potential issue is for static linking as
libestmp-config --libs may return more libraries than the hardcoded
-lesmtp, but I guess the autobuilders will tell us if that is the case.
--
Venlig hilsen,
Peter Korsgaard
prev parent reply other threads:[~2015-10-21 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 8:16 [Buildroot] [PATCH] syslog-ng: Specify location of libesmtp Chris Packham
2015-10-20 9:36 ` Peter Korsgaard
2015-10-20 9:40 ` Chris Packham
2015-10-20 10:03 ` Peter Korsgaard
2015-10-20 18:57 ` Peter Seiderer
2015-10-20 19:32 ` Peter Korsgaard
2015-10-21 7:41 ` Chris Packham
2015-10-21 8:27 ` Thomas Petazzoni
2015-10-21 9:45 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv14imhb.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox