From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/xbmc: Fix broken variable name
Date: Thu, 28 Aug 2014 08:54:09 +0200 [thread overview]
Message-ID: <87fvghrtny.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <XnsA3974DCE8DC95berndkuhlsPkbjNfxxIA@bernd-kuhls.de> (Bernd Kuhls's message of "Thu, 28 Aug 2014 07:38:55 +0200")
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> Hi,
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote in
> news:20140827213842.GB21009 at free.fr:
>>> Then we should imho get rid of the XBMC_DBUS option if that option
>>> doesn't do anything.
>>
>> That option does select BR2_PACKAGE_DBUS.
> should BR2_PACKAGE_DBUS in turn not select BR2_PACKAGE_XBMC_DBUS then?
No. The dbus package shouldn't know about xbmc (and kconfig won't allow
circular dependencies).
> Otherwise users might think DBUS is disabled for xbmc while it is enabled due
> to BR2_PACKAGE_DBUS. Otoh I could try to provide an xbmc/configure option
> --en/disable-dbus upstream.
Indeed. I think an explicit configure option would make most sense.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-08-28 6:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 20:41 [Buildroot] [PATCH] package/xbmc: Fix broken variable name Bernd Kuhls
2014-08-27 20:49 ` Yann E. MORIN
2014-08-27 21:11 ` Bernd Kuhls
2014-08-27 21:32 ` Peter Korsgaard
2014-08-27 21:38 ` Yann E. MORIN
2014-08-28 5:38 ` Bernd Kuhls
2014-08-28 6:54 ` Peter Korsgaard [this message]
2014-08-28 10:10 ` Yann E. MORIN
2014-08-28 6:52 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvghrtny.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox