From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/10] pkg-cmake.mk: build shared library when !BR2_PREFER_STATIC_LIB
Date: Sun, 19 Jan 2014 21:28:13 +0100 [thread overview]
Message-ID: <87fvojn2ci.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1390073027-14239-5-git-send-email-s.martin49@gmail.com> (Samuel Martin's message of "Sat, 18 Jan 2014 20:23:41 +0100")
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/pkg-cmake.mk | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index 463cd63..aedd1fc 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -64,6 +64,7 @@ define $(2)_CONFIGURE_CMDS
> $$($$(PKG)_CONF_ENV) $(HOST_DIR)/usr/bin/cmake $$($$(PKG)_SRCDIR) \
> -DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake" \
> -DCMAKE_INSTALL_PREFIX="/usr" \
> + -DBUILD_SHARED_LIBS=$(if $(BR2_PREFER_STATIC_LIB),OFF,ON) \
I don't know much about cmake, but what exact problem does this fix and
with how many packages did you test this?
> $$($$(PKG)_CONF_OPT) \
> )
> endef
> --
> 1.8.5.3
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-01-19 20:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 19:23 [Buildroot] [PATCH 00/10] Misc fixes Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 01/10] eigen: add C++ toolchain dependency Samuel Martin
2014-01-18 19:49 ` Yann E. MORIN
2014-01-19 20:16 ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 02/10] transmission: add url in Config.in Samuel Martin
2014-01-18 19:50 ` Yann E. MORIN
2014-01-19 20:16 ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 03/10] transmission: use <PKG>_INSTALL_INIT_SYSV infra instead of custom hook Samuel Martin
2014-01-18 19:52 ` Yann E. MORIN
2014-01-19 20:19 ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 04/10] pkg-cmake.mk: build shared library when !BR2_PREFER_STATIC_LIB Samuel Martin
2014-01-19 20:28 ` Peter Korsgaard [this message]
2014-01-24 0:08 ` Yann E. MORIN
2014-01-18 19:23 ` [Buildroot] [PATCH 05/10] qt: add an option to install the test module Samuel Martin
2014-02-11 20:06 ` Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 06/10] opencv: fix qt selection when highgui is enable Samuel Martin
2014-02-11 20:07 ` Samuel Martin
2014-01-18 19:23 ` [Buildroot] [PATCH 07/10] connman: add systemd unit file Samuel Martin
2014-01-18 19:56 ` Yann E. MORIN
2014-01-18 22:19 ` Lucas De Marchi
2014-01-18 19:23 ` [Buildroot] [PATCH 08/10] support: mkusers: add warning when using mkpasswd from the host system Samuel Martin
2014-01-19 20:29 ` Peter Korsgaard
2014-01-19 21:29 ` Yann E. MORIN
2014-01-18 19:23 ` [Buildroot] [PATCH 09/10] urg: make sdl support optional Samuel Martin
2014-01-18 20:00 ` Yann E. MORIN
2014-01-19 20:31 ` Peter Korsgaard
2014-01-18 19:23 ` [Buildroot] [PATCH 10/10] hostapd: fix static build failure Samuel Martin
2014-01-18 20:05 ` Yann E. MORIN
2014-02-10 11:53 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvojn2ci.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox