Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] RFC dependencies: checking minimum make version
Date: Thu, 01 Dec 2011 20:07:29 +0100	[thread overview]
Message-ID: <87fwh4glfy.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAAXf6LW__qfNLx-9jPsx+B_t9MMw4Uinti6+PrP7GzY+1X5mVg@mail.gmail.com> (Thomas De Schampheleire's message of "Thu, 1 Dec 2011 12:49:14 +0100")

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

Hi,

 Thomas> 2. Check for the make version in make instead of in shell, e.g. with
 Thomas> the following pattern: (adopted from
 Thomas> http://www.jgc.org/blog/cookbook-sample.pdf)
 Thomas> need := 3.81
 Thomas> ok := $(filter $(need),$(firstword $(sort $(MAKE_VERSION) $(need))))
 Thomas> ifeq (,$(ok))
 Thomas> $(error make too old!)
 Thomas> endif

 Thomas> This will not work when make 10.x comes out because of the sort trick,
 Thomas> but otherwise should work fine. This code should be included as early
 Thomas> as possible in the Makefile.

 Thomas> What do you think?

The likelyhood of people using <3.81 is probably getting fairly small,
but I'm OK with such a test (with a better error message and variables
though)@the top of the main Makefile.

Out of interest, on what system did you hit this?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-12-01 19:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 11:49 [Buildroot] RFC dependencies: checking minimum make version Thomas De Schampheleire
2011-12-01 19:07 ` Peter Korsgaard [this message]
2011-12-02  7:56   ` Thomas De Schampheleire
2011-12-02  8:29     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwh4glfy.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox