Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] 2010.02-rc1 at91sam9260pf_defconfig
Date: Thu, 18 Feb 2010 12:01:06 +0100	[thread overview]
Message-ID: <87fx4y24gd.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <815f0bd71002171828u4ac0f44dgc0df709ef7278a3d@mail.gmail.com> (Roo's message of "Thu, 18 Feb 2010 13:28:03 +1100")

>>>>> "Roo" == Roo  <roo.watt@gmail.com> writes:

Hi,

 Roo> I am new to buildroot, so if I should have done anything
 Roo> differently please let me know. I promise not to take in
 Roo> personally. :)

Thanks, committed. The patch contents was fine, but you made a few small
mistakes:

- You didn't configure your email program to use your full name /
  address
- Your commit message (top of mail) didn't explain what your patch fixes
- You didn't sign off on the change (git format-patch -s)
- Your patch was line wrapped by your mailer.

Please consider using git format-patch -s / git send-email in the
future, that will ensure you get (most) of those details correct.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2010-02-18 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18  2:28 [Buildroot] [PATCH] 2010.02-rc1 at91sam9260pf_defconfig Roo
2010-02-18 11:01 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fx4y24gd.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox