Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add fuse-sshfs package
Date: Tue, 24 Nov 2009 17:23:44 +0100	[thread overview]
Message-ID: <87fx83dh7z.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1259078918-15070-1-git-send-email-daniel@caiaq.de> (Daniel Mack's message of "Tue\, 24 Nov 2009 17\:08\:38 +0100")

>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:

 Daniel> +config BR2_PACKAGE_SSHFS
 Daniel> +	bool "sshfs (FUSE)"
 Daniel> +	depends on BR2_PACKAGE_LIBFUSE && BR2_PACKAGE_LIBGLIB2 && BR2_PACKAGE_OPENSSH

It's nice to keep lines < 80 chars. I would prefer 3 seperate 'depends on'
lines.

 Daniel> +	help
 Daniel> +	  FUSE makes it possible to implement a filesystem in a userspace
 Daniel> +	  program. Features include: simple yet comprehensive API, secure
 Daniel> +	  mounting by non-root users, support for 2.4 and 2.6 Linux
 Daniel> +	  kernels, multi-threaded operation. etc...

This sounds like a description of fuse itself, and not of sshfs?

 Daniel> +SSHFS_VERSION:=2.2
 Daniel> +SSHFS_SOURCE:=sshfs-fuse-$(SSHFS_VERSION).tar.gz
 Daniel> +SSHFS_SITE=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fuse/$(SSHFS_VERSION)/sshfs-fuse
 Daniel> +SSHFS_AUTORECONF:=NO
 Daniel> +SSHFS_INSTALL_STAGING:=NO
 Daniel> +SSHFS_INSTALL_TARGET:=YES
 Daniel> +
 Daniel> +SSHFS_DEPENDENCIES = libglib2

You're forgetting libfuse

Otherwise it looks good, thanks!

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-11-24 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 14:40 [Buildroot] [PATCH] Add fuse-sshfs package Daniel Mack
2009-11-24 15:44 ` Gustavo Zacarias
2009-11-24 15:56   ` Peter Korsgaard
2009-11-24 16:03     ` Daniel Mack
2009-11-24 16:23       ` Gustavo Zacarias
2009-11-24 16:08     ` Daniel Mack
2009-11-24 16:23       ` Peter Korsgaard [this message]
2009-11-24 16:29         ` Daniel Mack
2009-12-08  8:55           ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fx83dh7z.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox