[Buildroot] [PATCH] samba: updated the samba package to version 3.3.8

[Peter Korsgaard <jacmet@uclibc.org>]

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

Hi,

 Sven> From: rvpaasen <rvpaasen@t3i.nl>
 Sven> Update the samba package to the new makefile format and also update
 Sven> it to samba version 3.3.8 (latest 3.3.x version). Based on the
 Sven> patch from bug 665, but with uclibc dependency and call to
 Sven> autogen.sh removed.

Thanks, committed with a few minor fixes.

 Sven> +config BR2_PACKAGE_SAMBA_AVAHI
 Sven> +	bool "support avahi"
 Sven> +	default y
 Sven> +	depends on BR2_PACKAGE_SAMBA
 Sven> +	depends on BR2_PACKAGE_AVAHI
 Sven> +	help
 Sven> +	  Include support for avahi
 Sven> +
 Sven> +comment "support avhai - disabled (requires avahi)"
 Sven> +	depends on !BR2_PACKAGE_AVAHI

typo -> s/avhai/avahi/

 Sven> +	$(if $(BR2_PACKAGE_SAMBA_RPCCLIENT),readline,) \

'if' supports a 3 parameter form as well, so you can get rid of the last
comma - E.G.:

$(if $(BR2_PACKAGE_SAMBA_RPCCLIENT),readline)

Which is imho more readable.

 Sven> +SAMBA_CONF_OPT = \
 Sven> +	--localstatedir=/var \
 Sven> +	--with-piddir=/var/run \
 Sven> +	--with-lockdir=/var/lock \
 Sven> +	--with-logfilebase=/var/log \
 Sven> +	--with-configdir=/etc/samba \
 Sven> +	--with-privatedir=/etc/samba \
 Sven> +	\
 Sven> +	--disable-cups \

Long term we should probably enable cups support if enabled similar to
avahi/gamin.

-- 
Bye, Peter Korsgaard