From: Peter Korsgaard <peter@korsgaard.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: Thierry Bultel <thierry.bultel@linatsea.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/dracut: fix dracut_wrapper
Date: Mon, 18 Mar 2024 14:30:02 +0100 [thread overview]
Message-ID: <87h6h3fz1h.fsf@48ers.dk> (raw)
In-Reply-To: <20240225225728.2949216-1-romain.naour@smile.fr> (Romain Naour's message of "Sun, 25 Feb 2024 23:57:28 +0100")
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:
> As reported by Thierry Bultel [1], dracut doesn't work since the
> version bump to version 059.
> Further investigation by Andreas Naumann [2] reported that the issue
> come from this commit d010fa0 refactor(dracut-install): fork() instead
> of popen(), sanitise line reading [3].
> The issue come from our dracut_wrapper and how DRACUT_LDD is defined.
> Indeed dracut expect DRACUT_LDD=ldd or a single binary (without
> arguments) but we are using "prelink-rtld --root='${sysroot}'".
> With the change introduced by [3], our DRACUT_LDD is used
> directly by execlp() leading to an error:
> execlp(ldd, ldd, fullsrcpath, (char *)NULL);
> Use mktemp to generate a temporary dracut-ldd script using
> prelink-rtld --root='${sysroot}' ${1}
> execute dracut.real in a subshell to cleanup the temporary file
> at the end of the dracut wrapper script.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243423 [tests.fs.test_cpio.TestCpioDracutGlibcMergedUsr]
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243434 [tests.fs.test_cpio.TestCpioDracutMuslMergedUsr]
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243567 [tests.fs.test_cpio.TestCpioDracutUclibcMergedUsr]
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243559 [tests.fs.test_cpio.TestCpioDracutGlibc]
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243504 [tests.fs.test_cpio.TestCpioDracutUclibc]
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6224243498 [tests.fs.test_cpio.TestCpioDracutMusl]
> [1] http://lists.busybox.net/pipermail/buildroot/2024-February/684145.html
> [2] http://lists.busybox.net/pipermail/buildroot/2024-February/684503.html
> [3] https://github.com/dracutdevs/dracut/commit/d010fa0d7f8ef42ad31729d027d2e4be6dd6e588
> Fixes: 145f01ded5 ("package/dracut: bump to version 059")
> Reported-by: Thierry Bultel <thierry.bultel@linatsea.fr>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-18 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 22:57 [Buildroot] [PATCH] package/dracut: fix dracut_wrapper Romain Naour
2024-03-01 18:23 ` Peter Korsgaard
2024-03-18 13:30 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6h3fz1h.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@smile.fr \
--cc=thierry.bultel@linatsea.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox