Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2 v2] package/libjwt: new package
Date: Sat, 03 Feb 2024 11:02:48 +0100	[thread overview]
Message-ID: <87h6ipvp9z.fsf@48ers.dk> (raw)
In-Reply-To: <Zb0Qnnauhkwtp8Q0@waldemar-brodkorb.de> (Waldemar Brodkorb's message of "Fri, 2 Feb 2024 16:56:14 +0100")

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > JSON Web Tokens are an open, industry standard RFC 7519
 > method for representing claims securely between two parties.

 > This Library is used by Asterisk 20.6.0 and newer.
 > We need to use autotools to install pkgconfig file.

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
 > ---
 >  package/Config.in          |  1 +
 >  package/libjwt/Config.in   |  9 +++++++++
 >  package/libjwt/libjwt.hash |  3 +++
 >  package/libjwt/libjwt.mk   | 16 ++++++++++++++++
 >  4 files changed, 29 insertions(+)
 >  create mode 100644 package/libjwt/Config.in
 >  create mode 100644 package/libjwt/libjwt.hash
 >  create mode 100644 package/libjwt/libjwt.mk

 > diff --git a/package/Config.in b/package/Config.in
 > index 426bd7d090..75a94177eb 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -1846,6 +1846,7 @@ menu "JSON/XML"
 >  	source "package/libbson/Config.in"
 >  	source "package/libfastjson/Config.in"
 >  	source "package/libjson/Config.in"
 > +	source "package/libjwt/Config.in"
 >  	source "package/libroxml/Config.in"
 >  	source "package/libucl/Config.in"
 >  	source "package/libxml2/Config.in"
 > diff --git a/package/libjwt/Config.in b/package/libjwt/Config.in
 > new file mode 100644
 > index 0000000000..d6bca54adc
 > --- /dev/null
 > +++ b/package/libjwt/Config.in
 > @@ -0,0 +1,9 @@
 > +config BR2_PACKAGE_LIBJWT
 > +	bool "libjwt"
 > +	select BR2_PACKAGE_OPENSSL
 > +	select BR2_PACKAGE_JANSSON
 > +	help
 > +	  JSON Web Tokens are an open, industry standard RFC 7519 

I've dropped the trailing spaces here.

> diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk
 > new file mode 100644
 > index 0000000000..f7be28d206
 > --- /dev/null
 > +++ b/package/libjwt/libjwt.mk
 > @@ -0,0 +1,16 @@
 > +################################################################################
 > +#
 > +# libjwt
 > +#
 > +################################################################################
 > +
 > +LIBJWT_VERSION = 1.15.3
 > +LIBJWT_SITE = $(call github,benmcollins,libjwt,v$(LIBJWT_VERSION))
 > +LIBJWT_SOURCE = libjwt-$(LIBJWT_VERSION).tar.gz

THis is the default value for _SOURCE as pointed out by
./utils/check-package, so I've dropped that.

> +LIBJWT_DEPENDENCIES = jansson openssl

The configure script uses pkg-config, so I've added host-pkgconf here.

You also forgot to add an entry to DEVELOPERS, so I've added that.

Committed with those fixes, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-02-03 18:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 15:56 [Buildroot] [PATCH 1/2 v2] package/libjwt: new package Waldemar Brodkorb
2024-02-03 10:02 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6ipvp9z.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox