From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/9] package make: build RISC-V nommu builds as linux
Date: Sun, 11 Jul 2021 06:39:08 +0300 [thread overview]
Message-ID: <87h7h1h63n.fsf@tarshish> (raw)
In-Reply-To: <20210709063641.277005-4-damien.lemoal@wdc.com>
Hi Damien,
On Fri, Jul 09 2021, Damien Le Moal wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Using *-uclinux-* seems like an only partially followed convention.
> And at least for RISC-V gcc doesn't know about uclinux tuples, so
> switch back to the normal Linux one for now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> [Damien]
> * Make the change conditional on BR2_riscv arch being "y".
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> package/Makefile.in | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 86db62ba5b..a5eeb00872 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -39,9 +39,14 @@ endif
> # Compute GNU_TARGET_NAME
> GNU_TARGET_NAME = $(ARCH)-$(TARGET_VENDOR)-$(TARGET_OS)-$(LIBC)$(ABI)
>
> -# FLAT binary format needs uclinux
> +# FLAT binary format needs uclinux, except RISC-V which needs
> +# the regular linux name.
> ifeq ($(BR2_BINFMT_FLAT),y)
> +ifeq ($(BR2_riscv),y)
> +TARGET_OS = linux
> +else
> TARGET_OS = uclinux
> +endif
Maybe simplify the conditions part like this:
ifeq ($(BR2_BINFMT_FLAT):$(BR2_riscv),y:)
TARGET_OS = uclinux
else
TARGET_OS = linux
endif
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2021-07-11 3:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 6:36 [Buildroot] [PATCH 0/9] Add RISC-V NOMMU and Canaan K210 SoC support Damien Le Moal
2021-07-09 6:36 ` [Buildroot] [PATCH 1/9] arch/config: Make RISC-V MMU optional Damien Le Moal
2021-07-12 3:20 ` Alistair Francis
2021-07-09 6:36 ` [Buildroot] [PATCH 2/9] package/elf2flt: add RISC-V support Damien Le Moal
2021-07-09 6:36 ` [Buildroot] [PATCH 3/9] package make: build RISC-V nommu builds as linux Damien Le Moal
2021-07-11 3:39 ` Baruch Siach [this message]
2021-07-09 6:36 ` [Buildroot] [PATCH 4/9] board: Add Sipeed MAIX-bit support Damien Le Moal
2021-07-12 22:15 ` Alistair Francis
2021-07-09 6:36 ` [Buildroot] [PATCH 5/9] board: Add Sipeed MAIX-Go support Damien Le Moal
2021-07-12 22:16 ` Alistair Francis
2021-07-09 6:36 ` [Buildroot] [PATCH 6/9] board: Add Sipeed MAIXDUINO support Damien Le Moal
2021-07-12 22:41 ` Alistair Francis
2021-07-09 6:36 ` [Buildroot] [PATCH 7/9] board: Add Sipeed MAIX-Dock support Damien Le Moal
2021-07-12 22:43 ` Alistair Francis
2021-07-09 6:36 ` [Buildroot] [PATCH 8/9] board: Add Canaan KD233 support Damien Le Moal
2021-07-09 6:36 ` [Buildroot] [PATCH 9/9] board: Document Canaan K210 based boards support Damien Le Moal
2021-07-13 4:07 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7h1h63n.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox