From mboxrd@z Thu Jan  1 00:00:00 1970
From: Baruch Siach <baruch@tkos.co.il>
Date: Tue, 30 Oct 2018 13:38:04 +0200
Subject: [Buildroot] [PATCH 2/2] lighttpd: add optional pam support
In-Reply-To: <20181030102152.9755-2-peter@korsgaard.com>
References: <20181030102152.9755-1-peter@korsgaard.com>
 <20181030102152.9755-2-peter@korsgaard.com>
Message-ID: <87h8h38y1v.fsf@tkos.co.il>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi Peter,

Peter Korsgaard writes:
> Let the option depend on linux-pam as pam has quite some dependencies and
> this is unlikely to be used if pam isn't explicitly enabled.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/lighttpd/Config.in   | 7 +++++++
>  package/lighttpd/lighttpd.mk | 8 +++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/package/lighttpd/Config.in b/package/lighttpd/Config.in
> index 383c10f70f..0f37422aea 100644
> --- a/package/lighttpd/Config.in
> +++ b/package/lighttpd/Config.in
> @@ -26,6 +26,13 @@ config BR2_PACKAGE_LIGHTTPD_OPENSSL
>  	help
>  	  Enable OpenSSL support for lighttpd.
>  
> +config BR2_PACKAGE_LIGHTTPD_PAM
> +       bool "pam authentication support"
> +       depends on BR2_PACKAGE_LINUX_PAM
> +       default y
> +       help
> +         Enable PAM authentication support for lighttpd.
> +

Why do we need a config option? What is the size impact of the lighttpd
PAM support?

baruch

>  config BR2_PACKAGE_LIGHTTPD_ZLIB
>  	bool "zlib support"
>  	select BR2_PACKAGE_ZLIB
> diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk
> index 44bee6f90f..d8f64dc7e8 100644
> --- a/package/lighttpd/lighttpd.mk
> +++ b/package/lighttpd/lighttpd.mk
> @@ -12,7 +12,6 @@ LIGHTTPD_LICENSE = BSD-3-Clause
>  LIGHTTPD_LICENSE_FILES = COPYING
>  LIGHTTPD_DEPENDENCIES = host-pkgconf
>  LIGHTTPD_CONF_OPTS = \
> -	--without-pam \
>  	--without-wolfssl \
>  	--libdir=/usr/lib/lighttpd \
>  	--libexecdir=/usr/lib
> @@ -24,6 +23,13 @@ else
>  LIGHTTPD_CONF_OPTS += --without-openssl
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIGHTTPD_PAM),y)
> +LIGHTTPD_DEPENDENCIES += linux-pam
> +LIGHTTPD_CONF_OPTS += --with-pam
> +else
> +LIGHTTPD_CONF_OPTS += --without-pam
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIGHTTPD_ZLIB),y)
>  LIGHTTPD_DEPENDENCIES += zlib
>  LIGHTTPD_CONF_OPTS += --with-zlib


-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -