Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] ltrace: remove bogus comment in Config.in file
Date: Mon, 11 Jun 2018 23:17:29 +0200	[thread overview]
Message-ID: <87h8m981li.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180519205502.23746-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Sat, 19 May 2018 22:55:01 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > In commit dfaa18af00dfcff71a0159adaafb0880e58fa6a1 ("ltrace: disable
 > on mips/mipsel"), ltrace was disabled on mips/mipsel due to build
 > issues, and a comment was added in the Config.in file to explain that
 > even though ltrace has mips/mipsel support, it isn't enabled because
 > it doesn't build.

 > Then, in commit d23cce19c299e3010ba2dca84ab4ad35eff3cdbb ("ltrace:
 > enable for mips/mipsel"), the build of ltrace on mips/mipsel was
 > re-enabled, because it has been fixed upstream.

 > However, the comment in the Config.in comment was not removed in this
 > commit. Due to this, we have a comment that says "we don't allow
 > enabling ltrace on mips/mipsel" and the line right below precisely
 > allows to enable ltrace on mips/mipsel.

 > Fix this inconsistency by removing the no longer valid comment.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2018-06-11 21:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19 20:55 [Buildroot] [PATCH 1/2] ltrace: remove bogus comment in Config.in file Thomas Petazzoni
2018-05-19 20:55 ` [Buildroot] [PATCH 2/2] ltrace: fix visibility of Config.in comment Thomas Petazzoni
2018-06-11 21:17   ` Peter Korsgaard
2018-05-20 17:25 ` [Buildroot] [PATCH 1/2] ltrace: remove bogus comment in Config.in file Thomas Petazzoni
2018-06-11 21:17 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8m981li.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox