From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Tue, 17 Nov 2015 10:09:26 +0100 Subject: [Buildroot] [PATCH 4/6] package/libcurl: carefully override LD_LIBRARY_PATH In-Reply-To: <2fcbe9513b2535d0d0e0075cb57e079d8416db0a.1447449754.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Fri, 13 Nov 2015 22:48:50 +0100") References: <2fcbe9513b2535d0d0e0075cb57e079d8416db0a.1447449754.git.yann.morin.1998@free.fr> Message-ID: <87h9kldmbd.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: > To build libcurl, we need to override LD_LIBRARY and force it to a sane > value, otherwise libcurl is confused when target == host (see a51ce319, > libcurl: fix configure with openssl when target == host). > That is currently OK, since we always set LD_LIBRARY_PATH to a non-empty > value. > However, we're soon to stop setting it at all. > So, if the user has an empty (or no) LD_LIBRARY_PATH in his envirnment, > we'd end up adding the current working directory to LD_LIBRARY_PATH (as > an empty entry in a colon-separated list is most probably interpreted as > meaning the currentworking directory, which we do know can cause issue, > and which we expfressely check against in support/dependencies/dependencies.sh > Fix that by only using an existing LD_LIBRARY_PATH if it is not empty. > Also use a Makefile construct as it is easier to read than a shell one > (we can do that, as all variables from the environment as available as > make variables). > Signed-off-by: "Yann E. MORIN" > Cc: Peter Korsgaard > Cc: Thomas Petazzoni Committed, thanks. -- Bye, Peter Korsgaard