From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/shairport-sync: fix static builds
Date: Mon, 01 Dec 2014 00:11:55 +0100 [thread overview]
Message-ID: <87h9xgi8qs.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1417347776-25907-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sun, 30 Nov 2014 12:42:56 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Because shairport-sync uses AC_CHECK_LIB to find some of the needed
> libraries (opensl, alsa, popt...), it fails to bring in the dependencies
> of those libraries; for example, -lssl requires -lz.
> When doing a dynamically-linked build, those dependent libraries are
> pulled in thansk to the DT_NEEDED ELF tags, but those are not available
> in static libraries.
> Use PKG_CHECK_MODULES instead of AC_CHECK_LIB, and emulate the results
> of AC_CJECK_LIB (i.e. set the HAVE_LIBxxx and the LIBS variable
> appropriately) to minimise the amount of code touched.
> This should fix:
> http://autobuild.buildroot.net/results/1a5/1a56dbff3583bed0d693508dfc16859086846ecd/
> http://autobuild.buildroot.net/results/6d5/6d5a8157592f7a2c9469bf71b0453796ef982ab1/
> At the same time, remove a comment at the end of a variable assignment,
> since this has proven to cause some problems.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: J?rg Krause <jkrause@posteo.de>
> Cc: Baruch Siach <baruch@tkos.co.il>
> ---
> Changes v1 -> v2:
> - add missing host-pkgconf (Baruch)
> - remove end-of-line comment
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-11-30 23:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 11:42 [Buildroot] [PATCH] package/shairport-sync: fix static builds Yann E. MORIN
2014-11-30 23:11 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-29 13:34 Yann E. MORIN
2014-11-29 18:10 ` Baruch Siach
2014-11-29 18:15 ` Yann E. MORIN
2014-11-30 11:35 ` Yann E. MORIN
2014-11-30 12:09 ` Jörg Krause
2014-11-30 13:48 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9xgi8qs.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox