Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] netsnmp: bump to 5.7.1 LTS
Date: Tue, 06 Dec 2011 20:00:19 +0100	[thread overview]
Message-ID: <87hb1dr0e4.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <b999e4c6f3d2325cef6ec1aa713c45ad@zacarias.com.ar> (Gustavo Zacarias's message of "Tue, 06 Dec 2011 15:18:02 -0300")

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

Hi,

 Gustavo> Simple testcase for my failure:
 Gustavo> Run snmpd with a basic config and run a snmpwalk against localhost
 Gustavo> "snmpwalk -v 1 -c something localhost".
 Gustavo> The snmpd daemon will die before the walk is done.
 Gustavo> Rebuilding net-snmp with the patch fixes it.
 Gustavo> And a gdb backtrace points at closedir() exactly.
 Gustavo> Powerpc e300c3 target with latest gcc/binutils and uclibc 0.9.32.

Sorry, I missed the fact that include/dirent.h annotates closedir() with
__attribute__((nonnull)), which probably makes GCC drop the redundant if
(!dir) check.

I don't see any specific requirement in susv3 that it should handle NULL
pointers, so the patch seems OK:

http://www.bcs.zp.ua/manuals/en/susv3/functions/closedir.html

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-12-06 19:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06  9:43 [Buildroot] [PATCH] netsnmp: bump to 5.7.1 LTS Luca Ceresoli
2011-12-06 10:43 ` Gustavo Zacarias
2011-12-06 10:58   ` Peter Korsgaard
2011-12-06 11:11   ` Luca Ceresoli
2011-12-06 11:15     ` Gustavo Zacarias
2011-12-06 12:20     ` Gustavo Zacarias
2011-12-06 18:09       ` Peter Korsgaard
2011-12-06 18:18         ` Gustavo Zacarias
2011-12-06 19:00           ` Peter Korsgaard [this message]
2011-12-06 10:48 ` Peter Korsgaard
2011-12-06 16:50 ` [Buildroot] [PATCH v2] " Luca Ceresoli
2011-12-06 16:54   ` Gustavo Zacarias
2011-12-06 19:01   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hb1dr0e4.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox