[Buildroot] [PATCH 04/10] binutils: make it a proper package

[Peter Korsgaard <jacmet@uclibc.org>]

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> On 12/28/10 19:38, Peter Korsgaard wrote:
 >> Seeing this I thought the build would be broken because GCC isn't moved
 >> yet, but I see you do move it later on in this patch, even if it isn't
 >> mentioned in the commit message.

 Gustavo> Comment added.

Thanks.

 >> I find this quite complicated. I would prefer something like:
 >> 
 >> config BR2_PACKAGE_BINUTILS
 >> bool "binutils"
 >> depends on BR2_TOOLCHAIN_BUILDROOT
 >> help
 >> ..
 >> 
 >> config BR2_PACKAGE_BINUTILS_FULLINSTALL
 >> bool "perform full installation"
 >> depends on BR2_PACKAGE_BINUTILS
 >> help
 >> Select this to install all binary utilies and not just libbfd.
 >> 
 >> And then move the MPC/MPFR/GMP selects under
 >> BR2_PACKAGE_GCC_TARGET. Also add selects for BR2_PACKAGE_BINUTILS +
 >> FULLINSTALL.

 Gustavo> Easier to define BR2_PACKAGE_BINUTILS that builds all
 Gustavo> of binutils and only installs libbfd + BR2_PACKAGE_BINUTILS_TARGET to
 Gustavo> install the full version.

Yes, that's what I meant about the _FULLINSTALL option.

 >> You have trailing spaces here and elsewhere.

 Gustavo> Hopefully fixed.

Thanks.

 Gustavo> $(GCC_BUILD_DIR1)/.compiled: $(GCC_BUILD_DIR1)/.configured
 Gustavo> -	# gcc >= 4.3.0 have to also build all-target-libgcc
 >> 
 >> Why are you removing those comments? We still support gcc 4.2.x

 Gustavo> Because these are in STAGE1 (DIR1) where it's completely irrelevant /
 Gustavo> doesn't apply and just amounts to misinformation.
 Gustavo> gcc-initial doesn't use nor install headers since the extra gcc build
 Gustavo> stage was added. Same scenario for libgcc.
 Gustavo> They're leftover comments. That's the reason i kept the ones in
 Gustavo> gcc-intermediate.

Ahh ok, thanks.

 >> Why remove this ARCH_IS_64 stuff?

 Gustavo> This is from commit 3c77bab2eeace3ee675bd745ca335fa3dd1630bb
 Gustavo> which does a symlink trick to make libstdc++ available. It's
 Gustavo> simpler to just copy libstdc++ (and libgcj/libgcc while at it)
 Gustavo> to the sysroot which is fixed in patch #5 from my series.

Ok, good.

-- 
Bye, Peter Korsgaard