From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] cloop: bump and fix package
Date: Tue, 28 Dec 2010 20:14:55 +0100 [thread overview]
Message-ID: <87hbdxlnf4.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <0d679df871b997afde6b8bd5aceac6c831cafd45.1292492846.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 16 Dec 2010 10:47:34 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> On a machine without zlib-dev installed, cloop must really on the
s/really/rely/
Thomas> host-zlib compiled by Buildroot, but due to the horrible cloop build
Thomas> system, this didn't happen and the build was failing.
Thomas> Therefore, we now pass all the $(HOST_CONFIGURE_OPTS) when building
Thomas> cloop, and we fix the Makefile so that it takes into CFLAGS/LDFLAGS
+account
Thomas> define HOST_CLOOP_BUILD_CMDS
Thomas> - $(HOST_MAKE_ENV) $(MAKE1) \
Thomas> - CFLAGS="$(HOST_CFLAGS) -Wall -O2 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DUSE_ERROR_SILENT" -C $(@D) APPSONLY=yes
Thomas> + $(HOST_CONFIGURE_OPTS) $(HOST_MAKE_ENV) $(MAKE1) -C $(@D) APPSONLY=yes
HOST_CONFIGURE_OPTS is a superset of HOST_MAKE_ENV, so that one can be
dropped.
Committed with those minor fixes, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2010-12-28 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 9:47 [Buildroot] [pull request] Pull request for branch cloop-fix Thomas Petazzoni
2010-12-16 9:47 ` [Buildroot] [PATCH 1/1] cloop: bump and fix package Thomas Petazzoni
2010-12-28 19:14 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbdxlnf4.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox