From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Bernd Kuhls <bernd@kuhls.net>,
Romain Naour <romain.naour@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/mesa3d: rework dri3 handling
Date: Thu, 21 Mar 2024 21:49:59 +0100 [thread overview]
Message-ID: <87il1f48eg.fsf@48ers.dk> (raw)
In-Reply-To: <af2a398a-8147-4a86-8df0-b74b58114325@mind.be> (Arnout Vandecappelle via buildroot's message of "Fri, 15 Mar 2024 20:30:54 +0100")
>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:
> On 14/03/2024 22:15, Bernd Kuhls wrote:
>> From: Bernd Kuhls <bernd.kuhls@t-online.de>
> Could you make sure that your From is set the same as your SoB?
>> While fixing a build error
>> ../src/egl/drivers/dri2/platform_x11.c: In function
>> 'dri2_x11_get_msc_rate':
>> ../src/egl/drivers/dri2/platform_x11.c:1229:44:
>> error: 'struct dri2_egl_display' has no member named 'screen_resources'
>> with this defconfig:
>> BR2_x86_64=y
>> BR2_TOOLCHAIN_BUILDROOT_CXX=y
>> BR2_PACKAGE_MESA3D=y
>> BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_IRIS=y
>> BR2_PACKAGE_MESA3D_OPENGL_GLX=y
>> BR2_PACKAGE_MESA3D_OPENGL_EGL=y
>> BR2_PACKAGE_MESA3D_OPENGL_ES=y
>> BR2_PACKAGE_XORG7=y
>> (crocus and i915 drivers are also affected) it turns out that we can
>> assume the need for dri3 support when X.org is enabled as a hard depen-
>> dency even if mesa3d's configure does not throw errors when missing,
>> like for the Intel drivers.
>> Before this patch these Config.in options were used:
>> config BR2_PACKAGE_MESA3D_DRI3
>> select BR2_PACKAGE_XLIB_LIBXSHMFENCE
>> select BR2_PACKAGE_MESA3D_DRI3 if BR2_PACKAGE_XORG7
> THere was another select like that in
> BR2_PACKAGE_MESA3D_VULKAN_DRIVER_BROADCOM. I removed that one as
> well, and applied to master, thanks.
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-21 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 21:15 [Buildroot] [PATCH v2 1/1] package/mesa3d: rework dri3 handling Bernd Kuhls
2024-03-15 19:30 ` Arnout Vandecappelle via buildroot
2024-03-21 20:49 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il1f48eg.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=bernd.kuhls@t-online.de \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox