From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/scripts/pkg-stats: fix running on older python versions
Date: Thu, 29 Feb 2024 17:05:14 +0100 [thread overview]
Message-ID: <87il27dznp.fsf@48ers.dk> (raw)
In-Reply-To: <20240228224459.2383336-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 28 Feb 2024 23:44:59 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Commit f71d9f49e546 (support/scripts/pkg-stats: fix datetime deprecation
> warning) forgot to consider that the datetime.UTC suggested by python
> 3.12, was only introduced with python 3.11.
> However, we are still generating the daily report on a python 3.8
> version, which fails at runtime:
> AttributeError: module 'datetime' has no attribute 'UTC'
> It turns out that datetime.UTC is just an alias for datetime.timezone.utc,
> which seems to have existed since before python3...
> Use datetime.timezone.utc instead of its alias.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Committed, thanks.
> ---
> support/scripts/pkg-stats | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
> index 9a4a3ccad5..53898a36f2 100755
> --- a/support/scripts/pkg-stats
> +++ b/support/scripts/pkg-stats
> @@ -1290,7 +1290,7 @@ def __main__():
> package_list = set([v["name"] for v in show_info_js.values() if 'name' in v])
> else:
> package_list = None
> - date = datetime.datetime.now(datetime.UTC)
> + date = datetime.datetime.now(datetime.timezone.utc)
> commit = subprocess.check_output(['git', '-C', brpath,
> 'rev-parse',
> 'HEAD']).splitlines()[0].decode()
> --
> 2.43.2
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-29 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 22:44 [Buildroot] [PATCH] support/scripts/pkg-stats: fix running on older python versions Yann E. MORIN
2024-02-29 16:05 ` Peter Korsgaard [this message]
2024-02-29 16:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il27dznp.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox