From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48032C433F5 for ; Mon, 2 May 2022 04:53:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DFE1081A8E; Mon, 2 May 2022 04:53:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LqjJY-HdB0z1; Mon, 2 May 2022 04:53:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id F1B6E81A12; Mon, 2 May 2022 04:53:06 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DFDDD1BF408 for ; Mon, 2 May 2022 04:53:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C74C04093E for ; Mon, 2 May 2022 04:53:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=tkos.co.il Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WBVeDOPP94xR for ; Mon, 2 May 2022 04:53:04 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.tkos.co.il (guitar.tkos.co.il [84.110.109.230]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5541040942 for ; Mon, 2 May 2022 04:53:04 +0000 (UTC) Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id BED83440E72; Mon, 2 May 2022 07:52:09 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1651467130; bh=/ANvbzC26q2o5Vee2gtpxWIN9GPzpQkdl+Hn7pM48p4=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=i7XqQgfh40uTDgLDoU95BfIr3ohW2uNdr5fVAntMMALEXXliYrO/xanvC0+9Q7xds VAUSWJqz2m8lNUjzE+XUdFjGHGAyUJHjMbiWEStYi2cH/FBtpObGLjzCG1ooc2iasV zcPC0Sl29nXtKPh9BdC9lCKbfUXR5AQvItsRZ+iva+BRZgsqB8Qofq4lEQ26UNtuTN YnwZa8RuGiI+RIG8HW9QuqtYvhrvISnQ7hVvQAeFIghta7O5ZZJMZvtyrFLj9o78nt nXu2kDWlCvaLaqOmn0baqmydOdbbDaMy2XMvI6DNLlkhKOaEj++nLXKoM0LSj8FBNp F3C5MV5pIzP4Q== References: <20220502040500.93634-1-charles.hardin@chargepoint.com> <87mtg0y3f8.fsf@tarshish> User-agent: mu4e 1.6.10; emacs 27.1 To: Charles Hardin Date: Mon, 02 May 2022 07:49:42 +0300 In-reply-to: Message-ID: <87ilqoy1qr.fsf@tarshish> MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/1] toolchain/toolchain-external: add aarch64 as a hostarch for arm tools X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Baruch Siach via buildroot Reply-To: Baruch Siach Cc: Thomas De Schampheleire , Romain Naour , Giulio Benetti , Thomas Petazzoni , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hi Charles, On Sun, May 01 2022, Charles Hardin wrote: > On Sun, May 1, 2022 at 9:16 PM Baruch Siach wrote: >> On Sun, May 01 2022, Charles Hardin wrote: >> > From: Charles Hardin >> > >> > The gcc toolchain is also released for an aarch64 host target and allow >> > that configuration to be used as part of the configuration. Tested on >> > on a aarch64 linux docker. >> > >> > Signed-off-by: Charles Hardin >> >> [...] >> >> > diff --git >> > a/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk >> > b/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk >> > index 4392205105..0f554953ec 100644 >> > --- a/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk >> > +++ b/toolchain/toolchain-external/toolchain-external-arm-arm/toolchain-external-arm-arm.mk >> > @@ -7,6 +7,10 @@ >> > TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION = 2021.07 >> > TOOLCHAIN_EXTERNAL_ARM_ARM_SITE = >> > https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)/binrel >> > >> > +ifeq ($(HOSTARCH),aarch64) >> > +TOOLCHAIN_EXTERNAL_ARM_ARM_SOURCE = >> > gcc-arm-10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)-aarch64-arm-none-linux-gnueabihf.tar.xz >> > +else >> > TOOLCHAIN_EXTERNAL_ARM_ARM_SOURCE = >> > gcc-arm-10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)-x86_64-arm-none-linux-gnueabihf.tar.xz >> > +endif >> >> Maybe just >> >> TOOLCHAIN_EXTERNAL_ARM_ARM_SOURCE = >> gcc-arm-10.3-$(TOOLCHAIN_EXTERNAL_ARM_ARM_VERSION)-$(HOSTARCH)-arm-none-linux-gnueabihf.tar.xz > > Following the pattern seen in toolchain-external-linaro-arm.mk - no > problem changing it - for reference this is what i saw in the other > .mk > > ifeq ($(HOSTARCH),x86) > TOOLCHAIN_EXTERNAL_LINARO_ARM_SOURCE = > gcc-linaro-7.3.1-$(TOOLCHAIN_EXTERNAL_LINARO_ARM_VERSION)-i686_arm-linux-gnueabihf.tar.xz > else > TOOLCHAIN_EXTERNAL_LINARO_ARM_SOURCE = > gcc-linaro-7.3.1-$(TOOLCHAIN_EXTERNAL_LINARO_ARM_VERSION)-x86_64_arm-linux-gnueabihf.tar.xz > endif As strings i686 != x86, so you can't use HOSTARCH directly here. But I think we can use HOSTARCH directly where possible. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot