From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit branch/next] glibc: install glibc utils to target
Date: Sat, 23 Nov 2019 13:42:45 +0100 [thread overview]
Message-ID: <87imnayda2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAJ4jsaf_Oi35Md=sKwP1u+OWf=a8J2wSeMJxA=NJejtsMONo5w@mail.gmail.com> (Carlos Santos's message of "Sat, 23 Nov 2019 08:17:23 -0300")
>>>>> "Carlos" == Carlos Santos <unixmania@gmail.com> writes:
> On Sat, Nov 23, 2019 at 7:53 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>>
>> commit: https://git.buildroot.net/buildroot/commit/?id=c6cd512fe2e954b2ccc0412717c1c3380bc5f69b
>> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/next
>>
>> With this patch we introduce an option for glibc, which
>> installs getconf, ldconfig and ldd utilities on target, that
>> may be useful in debugging. By default these utilities are
>> built, but not installed to the target.
>> ldd is a bash script, so it has bash dependency.
>>
>> Signed-off-by: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
>> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>> ---
>> package/glibc/Config.in | 10 ++++++++++
>> package/glibc/glibc.mk | 7 +++++++
>> 2 files changed, 17 insertions(+)
>>
>> diff --git a/package/glibc/Config.in b/package/glibc/Config.in
>> index 7821251087..323767fc8a 100644
>> --- a/package/glibc/Config.in
>> +++ b/package/glibc/Config.in
>> @@ -8,3 +8,13 @@ config BR2_PACKAGE_GLIBC
>> help
>> https://www.gnu.org/software/libc/
>> endif
>> +
>> +config BR2_PACKAGE_GLIBC_UTILS
>> + bool "Install glibc utilities"
>> + depends on BR2_PACKAGE_BASH
>> + help
>> + Enabling this option will compile and install the getconf,
>> + ldconfig and ldd glibc utilities for the target.
>> +
>> +comment "glibc utilities need bash"
>> + depends on !BR2_PACKAGE_BASH
>> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
>> index c6acc43ff5..5cb19aabb9 100644
>> --- a/package/glibc/glibc.mk
>> +++ b/package/glibc/glibc.mk
>> @@ -143,10 +143,17 @@ ifeq ($(BR2_PACKAGE_GDB),y)
>> GLIBC_LIBS_LIB += libthread_db.so.*
>> endif
>>
>> +ifeq ($(BR2_PACKAGE_GLIBC_UTILS),y)
>> +GLIBC_TARGET_UTILS_BIN = posix/getconf elf/ldconfig elf/ldd
>> +endif
>> +
>> define GLIBC_INSTALL_TARGET_CMDS
>> for libpattern in $(GLIBC_LIBS_LIB); do \
>> $(call copy_toolchain_lib_root,$$libpattern) ; \
>> done
>> + $(foreach util,$(GLIBC_TARGET_UTILS_BIN), \
>> + $(INSTALL) -D -m 0755 $(@D)/build/$(util) $(TARGET_DIR)/bin/$(notdir $(util))
> The usual path of these utilities on non-merged-usr systems (e.g. RHEL-6) is:
> [root at rhel-6-1 ~]# which getconf ldconfig ldd
> /usr/bin/getconf
> /sbin/ldconfig
> /usr/bin/ldd
Yes, I noticed that as well. I've pushed a commit which fixes this -
Thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-11-23 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 10:53 [Buildroot] [git commit branch/next] glibc: install glibc utils to target Yann E. MORIN
2019-11-23 11:17 ` Carlos Santos
2019-11-23 12:40 ` Yann E. MORIN
2019-11-23 12:49 ` Yann E. MORIN
2019-11-23 12:42 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imnayda2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox